Kontact: iconsidepane spacing between icons (for Qt5.9.1)

Authored by winterz on Aug 24 2017, 9:42 PM.



Since I started using Qt5.9.1, the icons on the Kontact iconssidepane have been displayed too close together (see the pre-fix.png attachment)

This patch spaces the icons a little farther apart (see post-fix.png attachment)

Test Plan

I didn't try Qt5.8, but I know this problem wasn't in Qt5.7 as I used that version for a long time without seeing the text cutoff.

Diff Detail

R209 Kontact
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Aug 24 2017, 9:42 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 24 2017, 9:42 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

err.. how do I add attachments?

dvratil requested changes to this revision.Aug 25 2017, 1:28 PM

The post-fix looks weird - the icons are weirdly stretched out vertically.

I think the problem here is that when you change the icon size, the view does not re-query the sizeHint() and instead uses the old cached one for smaller icons. Just calling QAbstractItemView::reset() when you change the icon size should be good enough?

This revision now requires changes to proceed.Aug 25 2017, 1:28 PM

you're right. I hadn't noticed the stretching.
No the reset() didn't help that I recall. the text is cutoff on initial start of Kontact.

I'll need to look again.

winterz updated this revision to Diff 20169.EditedSep 30 2017, 9:21 PM

no longer see vertical stretching of the icons, but the spacing is nice now.

I put the new post-fix image at https://imagebin.ca/v/3cDE4o4vH19k

I find it strange that nobody else is complaining. Isn't anyone else using Qt5.9.x?

winterz updated this revision to Diff 23460.Dec 4 2017, 6:34 PM

update patch so it applies to cleanly to current source.
no functional changes

ngraham added a subscriber: ngraham.Dec 4 2017, 8:09 PM
dvratil accepted this revision.Dec 15 2017, 8:32 PM
This revision is now accepted and ready to land.Dec 15 2017, 8:32 PM

before I commit this...

since you approve, does that mean other folks are now encountering this problem? and I'm not delusional?

anthonyfieroni added a subscriber: anthonyfieroni.EditedDec 16 2017, 4:12 PM

I don't get it. Are you using Wayland?

I started noticing the icons being weird recently and remember your patch. Since I updated to Qt 5.9 since you first uploaded the patch (and I couldn't reproduce the problem there), I tried to apply the patch, restarted Kontact and haven't seen issues with the icons since, so I assume it fixed it. I did not go digging into Qt to see if it is really affected by the patch...

This revision was automatically updated to reflect the committed changes.

we can revert easily enough if this causes problems.
No I am not using Wayland.