Now I can load , configure , change and save the akonadi agents properly when using akonadi instance.
also added more description to the debug statements
Details
Details
Diff Detail
Diff Detail
- Repository
- R206 KMail
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/configuredialog/configureplugins/configurepluginslistwidget.cpp | ||
|---|---|---|
| 252 | I don't understand you need to add .instanceIdentifier to list of agent ? So I don't understand. could you verify which name have each instance in your system please ? | |
| src/configuredialog/configureplugins/configurepluginslistwidget.cpp | ||
|---|---|---|
| 252 | On l.249 we append the instance identifier to the service variable (which despite its name only contains the agent identifier like akonadi_foo_agent), so we need to append it to the id here too, otherwise the comparison on l.256 would never match. The question is if we really need to append the instance identifier to the service in the first place. I think we don't and that better fix would be just to remove l.248-l.250, and ideally rename interfaceName to agentIdentifier or something similar. This code has nothing to do with DBus, so I don't see a reason to use DBus terminology here. | |
Comment Actions
when I rollback the changes in createAgentPluginData(), I can no longer configure the agents in the plugin settings dialog. and I see the debug message
"org.kde.pim.kmail: interface does not exist when trying to configure the plugin"
when I say "rollback" I mean back to before Laurent added the initial code for dealing with instances.
Comment Actions
Ah, I did not notice that the service is being stored in extraInfo, I presume it's used somewhere for the Dbus service - I think it would be better if only the agent identifier would be stored and the code that uses it as part of Dbus service would append the Akonadi instance identifier, but that is probably out-of-scope for this patch.
Comment Actions
updated patch that that
- applies cleanly to master
- addresses Laurent's concerns
- renames the interface variable to agent, as requested by Dan