KOrganizer Summary Plugin: restore tooltips for appointments
ClosedPublic

Authored by winterz on Dec 6 2017, 6:13 PM.

Details

Summary

This patch brings back the tooltips for the appointment links in the Kontact summary plugin.

unfortunately, the summaryeventtest no longer builds and , although I ported it, it does need an Akonadi expert to make it work. so for now, this patch comments out the test.

I could use a volunteer to restore the summaryeventtest and make it work properly.

Test Plan

I can see the tooltips on the appointment links in the summary now.

the summaryeventtest is removed (for now).

Diff Detail

Repository
R210 KOrganizer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Dec 6 2017, 6:13 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 6 2017, 6:13 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
winterz requested review of this revision.Dec 6 2017, 6:13 PM
mlaurent requested changes to this revision.Dec 7 2017, 5:58 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/kontactplugin/korganizer/CMakeLists.txt
55 ↗(On Diff #23575)

Add a CMake warning otherwise we never readd this one if we don't know it.

src/kontactplugin/korganizer/summaryeventinfo.cpp
94

const'ref

240

rs == displayName no ? so better to rename as displaynName no ?

243

const Akonadi::Collection

289

const'ref here

src/kontactplugin/korganizer/summaryeventinfo.h
42

same const'ref and after too

This revision now requires changes to proceed.Dec 7 2017, 5:58 AM
winterz updated this revision to Diff 23654.Dec 8 2017, 3:27 PM

handles Laurent's comments

mlaurent accepted this revision.Dec 9 2017, 7:48 AM

I didn't know "return()" in cmake language cool :)

This revision is now accepted and ready to land.Dec 9 2017, 7:48 AM
This revision was automatically updated to reflect the committed changes.