This patch removes the ancient local copy of versit and replaces it with the same calls to the libical's icalvcal library.
Benefit: we let the libical people properly maintain.
Thanks to krop for adapting FindLibical.cmake
Details
Details
builds and make test still works
should continue work for people using ancient libical 1.0, but I would like to increase the min libical version to 2.0.
Diff Detail
Diff Detail
- Repository
- R172 KCalendar Core
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
"but I would like to increase the min libical version to 2.0." +1 I think that we can increase it.
Comment Actions
Should the entire versit directory be removed as well?
| src/vcalformat.h | ||
|---|---|---|
| 49 | Could we keep the includes in the .cpp file? | |
Comment Actions
yes, it is removed locally. I'll make a new patch to show that
| src/vcalformat.h | ||
|---|---|---|
| 49 | yes. right. I'll do that. | |