KCalUtils: new method tzUTCOffsetStr
ClosedPublic
Actions

Authored by winterz on Dec 9 2017, 6:38 PM.

Details

Reviewers

Commits

R173:6705bf168adf: new static method tzUTCOffsetStr for pretty printing UTC offset

Summary

This patch adds a new static method for pretty formatting a timezone's UTC offset.
We had an older version of this in eventviews, but I want to move it here for wider use.

Test Plan

I'm using it in eventviews ok.

Please double-check the "@since" value.

Diff Detail

Repository

R173 KCalendar Utils

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

winterz created this revision.Dec 9 2017, 6:38 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 9 2017, 6:38 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

winterz requested review of this revision.Dec 9 2017, 6:38 PM

improved. more unittests

fix two const + commit please
thanks

src/stringify.cpp
284	const same for other line

This revision is now accepted and ready to land.Dec 11 2017, 7:14 AM

Closed by commit R173:6705bf168adf: new static method tzUTCOffsetStr for pretty printing UTC offset (authored by winterz). · Explain WhyDec 11 2017, 2:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (22 lines)
M			autotests/teststringify.h (1 line)
M			autotests/teststringify.cpp (27 lines)
M			src/stringify.h (13 lines)
M			src/stringify.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23696			Dec 9 2017, 6:36 PM	★	★
Diff 2	23722			Dec 10 2017, 1:52 PM	★	★
Diff 3	23762	9c31ff3	R173:6705bf168adfb8faa119f0c57b423c57d627d247	Dec 11 2017, 2:21 PM	★	★