Work around an issue with changing the wallpaper's filetype
ClosedPublic

Authored by ngraham on Tue, Jan 28, 7:03 PM.

Details

Summary

Because of the issue described in T12611, changing the filetype of the Next wallpaper is
problematic and will cause a black screen on upgrade.

This terrible horrible patch works around the issue by using the .png filename extension
even though this is not accurate. That way, the file names are the same as the old
versions of the Next wallpaper and will be loaded correctly. Using the wrong filename
extension does not actually cause any problems, it's just inaccurate. a README file is
placed next to the images to explain this.

I'm sorry.

Long-term, we should investigate T12611.

Test Plan

Have previous Next wallpaper (Ice Cold) installed
Replace it on disk with Volna in original JPEG form
restart plasmashell -> black screen

Try the above again with this patch
restart plasmashell -> new wallpaper visible

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Tue, Jan 28, 7:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Jan 28, 7:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Tue, Jan 28, 7:03 PM
ognarb accepted this revision.Tue, Jan 28, 7:54 PM
This revision is now accepted and ready to land.Tue, Jan 28, 7:54 PM
This revision was automatically updated to reflect the committed changes.
bshah added a subscriber: bshah.Wed, Jan 29, 10:13 AM

This doesn't work on neon dev unstable and actually breaks the wallpaper.

This doesn't work. The image doesn't load. QImage shortcuts when it sees a ".png".
Are you sure you didn't leave the old wallpaper in the folder when you tested this? Or even had your "wallpaper cache" attempt patch still applied?

I didn't have the cache patch installed, but I probably forgot to delete the wallpapers from one of the several on-disk locations where they live. :/ reverted in bfe2152c5ef73e9f5b7ad03313f3a4ccef440a22.