Differential D28424

Add a new standalone executable to replace X-KDE-Autostart-Condition
ClosedPublic
Actions

Authored by hchain on Mar 30 2020, 9:20 AM.

Details

Reviewers
davidedmundson
broulik
dfaure
ngraham
meven
Commits
R120:6cd25ded9934: Add a new standalone executable to replace X-KDE-Autostart-Condition
Summary

For systemd autostart generator will add a ExecCondition=kde-systemd-start-condition rcfile:section:entry:default
As described in T12627. Needs D28421

Test Plan

Run kde-systemd-start-condition; should return 0 with a missing or incomplete argument, 255 with a false or non-existent and non-default con
fig value.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hchain created this revision.Mar 30 2020, 9:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2020, 9:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hchain requested review of this revision.Mar 30 2020, 9:20 AM
broulik added inline comments.Mar 30 2020, 9:20 AM
startkde/CMakeLists.txt
43

Do we rather want it in libexec since it's not meant to be run by the user?

davidedmundson added inline comments.Mar 30 2020, 9:22 AM
startkde/CMakeLists.txt
43

There's a bit of a challenge there.

We need this executable to be found by the xdg generator.
libexec seems to be all over the place across different packaging.

davidedmundson added a comment.Mar 30 2020, 9:59 AM

looks good to me, but lets delay merging till the relevant other parts are ready.

davidedmundson accepted this revision.Apr 6 2020, 2:19 PM
This revision is now accepted and ready to land.Apr 6 2020, 2:19 PM
meven added a comment.Apr 24 2020, 7:54 AM
In D28424#637869, @davidedmundson wrote:

looks good to me, but lets delay merging till the relevant other parts are ready.

Seems ready to land ;)

Closed by commit R120:6cd25ded9934: Add a new standalone executable to replace X-KDE-Autostart-Condition (authored by hchain). · Explain WhyJun 8 2020, 10:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 83248

View Options

startkde/CMakeLists.txt

Loading...
View Options

startkde/kde-systemd-start-condition.cpp

Loading...