hchain (Henri Chain)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2019, 2:45 PM (51 w, 2 h)
Availability
Available

Recent Activity

Jun 8 2020

hchain committed R120:6cd25ded9934: Add a new standalone executable to replace X-KDE-Autostart-Condition (authored by hchain).
Add a new standalone executable to replace X-KDE-Autostart-Condition
Jun 8 2020, 10:22 AM
hchain closed D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition.
Jun 8 2020, 10:22 AM · Plasma

Apr 21 2020

hchain edited P577 (An Untitled Masterwork).
Apr 21 2020, 5:16 PM

Apr 17 2020

hchain added inline comments to D28305: Systemd Startup.
Apr 17 2020, 5:23 PM · Plasma
hchain edited P577 (An Untitled Masterwork).
Apr 17 2020, 1:00 PM

Apr 10 2020

hchain edited P577 (An Untitled Masterwork).
Apr 10 2020, 10:13 PM
hchain edited P577 (An Untitled Masterwork).
Apr 10 2020, 10:12 PM

Apr 8 2020

hchain created P577 (An Untitled Masterwork) in the S1 KDE Community space.
Apr 8 2020, 1:20 PM

Apr 4 2020

hchain added inline comments to D28421: Add static method to check start condition.
Apr 4 2020, 9:43 AM · Frameworks

Apr 3 2020

hchain added a comment to D28510: [kprocessrunner] Escape hyphen characters in scope names.

The full systemd escape code is here: https://github.com/systemd/systemd/blob/master/src/basic/unit-name.c#L294

Apr 3 2020, 12:57 PM · Frameworks

Mar 30 2020

hchain committed R309:fe5c63b177a1: Add static method to check start condition (authored by hchain).
Add static method to check start condition
Mar 30 2020, 10:03 AM
hchain closed D28421: Add static method to check start condition.
Mar 30 2020, 10:03 AM · Frameworks
hchain requested review of D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition.
Mar 30 2020, 9:20 AM · Plasma
hchain updated the diff for D28421: Add static method to check start condition.

void

Mar 30 2020, 9:17 AM · Frameworks
hchain updated the test plan for D28421: Add static method to check start condition.
Mar 30 2020, 9:16 AM · Frameworks
hchain updated the diff for D28421: Add static method to check start condition.

remove binary

Mar 30 2020, 9:15 AM · Frameworks
hchain added inline comments to D28421: Add static method to check start condition.
Mar 30 2020, 8:20 AM · Frameworks
hchain requested review of D28421: Add static method to check start condition.
Mar 30 2020, 7:56 AM · Frameworks

Mar 26 2020

hchain added inline comments to D28305: Systemd Startup.
Mar 26 2020, 1:29 PM · Plasma
hchain added inline comments to D28305: Systemd Startup.
Mar 26 2020, 1:06 PM · Plasma
hchain added inline comments to D28305: Systemd Startup.
Mar 26 2020, 12:59 PM · Plasma

Mar 19 2020

hchain added a comment to T12729: KWinRules KCM Redesign.

Great!
I was thinking you might want to use pointer to RuleSettings members instead of config item name strings inside of RuleItem. Also maybe it would be worthwhile to make RuleItem a template (I think it doesn't need to be a QObject) instead of your Type enum.

Mar 19 2020, 2:28 PM · VDG, Plasma: KCM Redesign
hchain added a comment to T12729: KWinRules KCM Redesign.

Hi @iasensio , I can help with porting your code to KConfig XT . Do you mind if I rebase your branch and make some modifications ?

Mar 19 2020, 12:43 PM · VDG, Plasma: KCM Redesign

Mar 16 2020

hchain committed R108:518c85e91ec4: Remove default button on kwinrules KCM (authored by hchain).
Remove default button on kwinrules KCM
Mar 16 2020, 4:22 PM
hchain closed D28071: Remove default button on kwinrules KCM.
Mar 16 2020, 4:22 PM · KWin
hchain updated the diff for D28071: Remove default button on kwinrules KCM.

update summary

Mar 16 2020, 4:11 PM · KWin
hchain updated the summary of D28071: Remove default button on kwinrules KCM.
Mar 16 2020, 4:09 PM · KWin
hchain updated the summary of D28071: Remove default button on kwinrules KCM.
Mar 16 2020, 1:03 PM · KWin
hchain updated the summary of D28071: Remove default button on kwinrules KCM.
Mar 16 2020, 12:55 PM · KWin
hchain requested review of D28071: Remove default button on kwinrules KCM.
Mar 16 2020, 12:53 PM · KWin
hchain committed R108:7c1c9d8164d0: Port kwinrules kcm to kconfigxt (authored by hchain).
Port kwinrules kcm to kconfigxt
Mar 16 2020, 12:38 PM
hchain closed D27682: Port kwinrules kcm to kconfigxt.
Mar 16 2020, 12:38 PM · KWin
hchain added inline comments to D27682: Port kwinrules kcm to kconfigxt.
Mar 16 2020, 11:31 AM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Remove double delete smell

Mar 16 2020, 10:20 AM · KWin

Mar 13 2020

hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

cleanup

Mar 13 2020, 2:51 PM · KWin

Mar 9 2020

hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

fix stack overflow, export

Mar 9 2020, 5:37 PM · KWin
hchain added a comment to T12729: KWinRules KCM Redesign.

KConfig XT is based on KConfig, and there is an underlying KConfig Object with entries/groups. But the entire point of KConfig XT is not to use them, and use the auto generated accessors instead. The kconfig compiler can also make RuleBookSettings a QObject with Q_PROPERTIES and signals that you can connect to your model.

Mar 9 2020, 11:03 AM · VDG, Plasma: KCM Redesign

Mar 6 2020

hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

remove unecessary group deletion

Mar 6 2020, 6:37 PM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Move rulesettings* to source root

Mar 6 2020, 6:26 PM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

qAsConst

Mar 6 2020, 4:27 PM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

split loadAllInto/saveAllFrom

Mar 6 2020, 4:13 PM · KWin

Mar 3 2020

hchain added a comment to T12729: KWinRules KCM Redesign.

Hi @iasensio, great work on the UI redesign! I currently have a patch https://phabricator.kde.org/D27682 to port the existing kwinrules KCM to KConfig XT. Hopefully this can help bridge existing configuration with your model, as well as import/export.

Mar 3 2020, 1:01 PM · VDG, Plasma: KCM Redesign
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

add copyright

Mar 3 2020, 12:57 PM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Rename

Mar 3 2020, 12:53 PM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Add second kcfg, clean class hierachy

Mar 3 2020, 10:41 AM · KWin

Feb 28 2020

hchain committed R237:f98feb169813: fix min/max entries with dpointer (authored by hchain).
fix min/max entries with dpointer
Feb 28 2020, 9:21 AM
hchain closed D27717: fix min/max entries with dpointer.
Feb 28 2020, 9:21 AM · Frameworks
hchain requested review of D27717: fix min/max entries with dpointer.
Feb 28 2020, 8:57 AM · Frameworks

Feb 27 2020

hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Don't write item if rule is set to unused

Feb 27 2020, 9:28 AM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Cleanup

Feb 27 2020, 9:26 AM · KWin
hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Fix non-KCM build

Feb 27 2020, 9:23 AM · KWin

Feb 26 2020

hchain updated the diff for D27682: Port kwinrules kcm to kconfigxt.

Cleanup kcfgc

Feb 26 2020, 5:43 PM · KWin
hchain requested review of D27682: Port kwinrules kcm to kconfigxt.
Feb 26 2020, 5:32 PM · KWin
hchain accepted D27672: Fix tests after D27497.

Can confirm this works

Feb 26 2020, 10:02 AM · Frameworks

Feb 25 2020

hchain committed R237:d218b93a5350: Fix code generation for entries with min/max (authored by hchain).
Fix code generation for entries with min/max
Feb 25 2020, 2:58 PM
hchain closed D27497: Fix code generation for entries with min/max.
Feb 25 2020, 2:58 PM · Frameworks
hchain updated the diff for D27497: Fix code generation for entries with min/max.

add bugzilla

Feb 25 2020, 2:46 PM · Frameworks

Feb 24 2020

hchain updated the diff for D27497: Fix code generation for entries with min/max.

const, change method name, reformat code

Feb 24 2020, 5:23 PM · Frameworks

Feb 19 2020

hchain updated the diff for D27497: Fix code generation for entries with min/max.

Add reference files for other tests that were impacted

Feb 19 2020, 12:36 PM · Frameworks
hchain updated the diff for D27497: Fix code generation for entries with min/max.

Reduce number of lines in generated test code

Feb 19 2020, 12:29 PM · Frameworks
hchain updated the diff for D27497: Fix code generation for entries with min/max.

Yet more style fixes

Feb 19 2020, 12:20 PM · Frameworks
hchain updated the diff for D27497: Fix code generation for entries with min/max.

Fix Style/whitespace

Feb 19 2020, 12:16 PM · Frameworks
hchain accepted D27496: Fix is<PropertyName>Immutable generated property.

LGTM

Feb 19 2020, 11:39 AM · Frameworks
hchain requested review of D27497: Fix code generation for entries with min/max.
Feb 19 2020, 11:30 AM · Frameworks