Needed for systemd autostart generator will add a ExecCondition=kde-systemd-start-condition rcfile:section:entry:default, as described in T12627
Details
Details
Diff Detail
Diff Detail
- Repository
- R309 KService
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Code is fine; both the change in KAutostart and the helper.
I'm not sure if this the helper should be in the framework.
X-KDE-Autostart condition is very tied to Plasma doing the booting, at which point we're better off putting the binary in plasma-workspace/startkde somewhere.
| src/utils/kde-systemd-start-condition.cpp | ||
|---|---|---|
| 17 ↗ | (On Diff #78848) | Should it be showHelp(255)? Not that we should end up here in the generated case. |
| 20 ↗ | (On Diff #78848) | A group name can have a space in it. For example: I assume this will be ok as long as we make sure that we make the generator put things in quotes. But can you double check. |
| src/utils/kde-systemd-start-condition.cpp | ||
|---|---|---|
| 20 ↗ | (On Diff #78848) | As long as kde-systemd-start-condition "foo bar:foo bar:foo:true" does work properly, we can leave this as-is and just make sure the generator is correct. |
| src/services/kautostart.h | ||
|---|---|---|
| 289 | This is new public API, it's missing @since 5.69 | |
| src/services/kautostart.h | ||
|---|---|---|
| 289 | ||
| src/services/kautostart.h | ||
|---|---|---|
| 289 | I think you added it to the wrong method ;) | |
| src/services/kautostart.h | ||
|---|---|---|
| 289 | Fixed with 79fea5fc4043be72f3addf8980d4d78ef04530ff | |
Comment Actions
That was embarrassing, I shouldn't try and rush. Sorry. Thanks for cleaning up after me.