Differential D29034

Add systemd user service file for kded
ClosedPublic
Actions

Authored by broulik on Apr 21 2020, 6:58 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Frameworks
Commits
R297:4ae4de9ff469: Add systemd user service file for kded
Test Plan

See T11914 and D28305

Diff Detail

Repository
R297 KDED
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 21 2020, 6:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 21 2020, 6:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Apr 21 2020, 6:58 AM
broulik edited the summary of this revision. (Show Details)Apr 21 2020, 6:58 AM
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Frameworks.
broulik added inline comments.
src/plasma-kded.service.in
6

Didn't we have a KDE_INSTALL_BIN_DIR or something?

davidedmundson added a subscriber: davidedmundson.EditedApr 21 2020, 9:11 AM

We also need to change the installed DBus service file so that we link the two in the unlikely event that kded is activated by being messaged first.

I need to either update the dbus generator macro, or we skip the macro and put the service file in here, the old way

src/plasma-kded.service.in
6

@CMAKE_INSTALL_FULL_BINDIR@

7

Slice=session.slice

broulik planned changes to this revision.Apr 21 2020, 12:15 PM
bruns added a subscriber: bruns.Apr 23 2020, 2:38 PM
bruns added inline comments.
src/plasma-kded.service.in
6

How about using some LIBEXEC dir instead, this should never be called directly, or am I missing something?

broulik added inline comments.Apr 23 2020, 2:38 PM
src/plasma-kded.service.in
6

This is unrelated and kded has been there forever

broulik updated this revision to Diff 82868.May 14 2020, 4:11 PM
  • fix exec
  • add slice
davidedmundson accepted this revision.May 15 2020, 2:38 PM
This revision is now accepted and ready to land.May 15 2020, 2:38 PM
Closed by commit R297:4ae4de9ff469: Add systemd user service file for kded (authored by broulik). · Explain WhyMay 15 2020, 2:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (4 lines)
AMsrc/plasma-kded.service.in (7 lines)

Diff 82949

View Options

src/CMakeLists.txt

Loading...
View Options

src/plasma-kded.service.in

Loading...