Include only the largest size for the "Next" wallpaper
Changes PlannedPublic

Authored by ngraham on Jan 6 2019, 5:15 AM.


Group Reviewers
Maniphest Tasks
T10269: Improve wallpapers

Companion to D18005; everything there applies here too.

Disk space savings amounts to 18 MB.

Test Plan

Same as in D18005.

Diff Detail

R31 Breeze
keep-only-largest-size (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 6691
Build 6709: arc lint + arc unit
ngraham created this revision.Jan 6 2019, 5:15 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 6 2019, 5:15 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 6 2019, 5:15 AM
ngraham edited the summary of this revision. (Show Details)Jan 6 2019, 5:21 AM
ngraham edited the test plan for this revision. (Show Details)
filipf added subscribers: kvermette, filipf.EditedJan 6 2019, 10:46 AM

I've reproduced what the issue was before. Tests done with a 1280x1024 monitor.

  • Tested on a Kubuntu 16.04 (with backports = 5.8 LTS) install with Plasma

Using the optimized 1280x1024 wallpaper:

Using the scaled & cropped method with the 3840x2160 wallpaper:

As we can see the end result is not good - the wallpaper is blurry.

  • Tested on the latest Manjaro KDE stable snapshot

Using the scaled & cropped method with the 3840x2160 wallpaper:

The problem with blurriness is gone. We do, however, see that manual and automatic cropping don't have the same result.

Based on this, I think it should ultimately be up to @kvermette to decide if the automatic scaling and cropping will do injustice to his wallpapers. If so, it does also represent a minus point for Plasma's default presentation.

And from my understanding this removes the file the SDDM theme needs so I created D18007 as a dependent revision.

Thanks for noticing that!

ngraham edited the summary of this revision. (Show Details)Jan 8 2019, 8:20 PM
mart requested changes to this revision.Jan 9 2019, 3:43 PM
mart added a subscriber: mart.

has runtime memory been taken into account? (better with massif than with the unreliable top/ksysguard)
runtime memory usage should be taken into account as well, loading a big image just to use a little, is still very expensive never the less

This revision now requires changes to proceed.Jan 9 2019, 3:43 PM

According to @davidedmundson, runtime memory is unchanged because we internally store a version that's resized and cropped according to the actual screen dimensions and pixel density.

I said it's roughly unchanged, we resize to the uncropped version of the image.

As per IRC discussion yesterday. We can do it in the extra wallpapers, and see how that goes, lets not change "Next" this release.

ngraham planned changes to this revision.Jan 11 2019, 8:46 PM

Per discussion in D18005, we're not gonna do this for 5.15. Instead we'll try to get a local wallpaper cache, and then we can do it.