Kate: File menu: Put Save, Print and Export actions into submenus
Needs RevisionPublic

Authored by gregormi on Sat, Nov 24, 3:39 PM.

Details

Reviewers
ngraham
Group Reviewers
Kate
Summary

Depends on: https://phabricator.kde.org/D17137 ("With https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before.")

File menu BEFORE:

AFTER:

Screenshot updates pending:

  • Save As... will stay on top level
  • Three of the Close actions will get their own submenu
  • Final submenu names are not decided yet

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5319
Build 5337: arc lint + arc unit
gregormi created this revision.Sat, Nov 24, 3:39 PM
Restricted Application added a project: Kate. · View Herald TranscriptSat, Nov 24, 3:39 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Sat, Nov 24, 3:39 PM
gregormi edited the summary of this revision. (Show Details)Sat, Nov 24, 3:42 PM
gregormi added a reviewer: Kate.
gregormi edited the summary of this revision. (Show Details)
ngraham requested changes to this revision.Sat, Nov 24, 3:54 PM
ngraham added a subscriber: ngraham.

I approve of the goal of simplifying the menu presentation, but I'm not sure it's a good idea to hide the very commonly used actions Save As... and Print in sub-menus. For all the other ones, I think it's okay though.

How about something a bit more like this:

Save
Save As...
More Save Actions              >

...

Print...
More Print and Export Actions  >

...

Close
More Close Actions             >
This revision now requires changes to proceed.Sat, Nov 24, 3:54 PM
  • With Save As... I am also not sure. I thought it is a well-known operation which will be easily found even in a submenu and then there is the keyboard shortcut
  • Print: I think printing of text documents is so rare that putting it all into a submenu won't hurt - and can save paper ;-)
  • "More ABC Actions": this text feels a bit long. Maybe something like "More on ABC" or "ABC Advanced" or "ABC More" (like in Edit > Search More)?

I think we could maybe compromise with putting the Print action under a submenu as long as it has the word "Print" in it, like you originally had (e.g. "Print and Export" would be fine in that case). But I'm going to have to stick to my guns with Save As.... That one is super common and I think it deserves to be on the top level of the menu rather than in a sub-menu.

  • Keeping "Save As..." at the top level is fine with me.
  • Putting some of the Close actions in a submenu - as you suggested above - sounds good, too
  • How should the submenus be named?

I think we can postpone some of the decisions until and the general restructuring idea is approved by others.

gregormi edited the summary of this revision. (Show Details)Sat, Nov 24, 4:34 PM
gregormi edited the summary of this revision. (Show Details)

I think hiding the seldom used other actions is a good idea.
For the naming, I have no good taste for such things ;=)

For the case where the sub-menu replaces all currently visible items, I think what you currently have works great:

  • Print and Export

For cases where one or two common items are visible and the uncommon ones are un a sub-menu, my suggestion is "More <thing> Actions". So we could have:

  • More Save Actions
  • More Close actions
  • etc.

Open to other suggestions of course! :)

richardbowen added a subscriber: richardbowen.EditedSat, Nov 24, 7:53 PM

Print, Print Preview and Export are related but not variants and are fine on the first level of the menu; grouping them seems unnecessary.

Since there are many variants of Save and Close, a group for the other less used actions could work. But this may actually make things more complicated with deeper nested menus.

gregormi retitled this revision from File menu: Put Save, Print and Export actions into submenus to Kate: File menu: Put Save, Print and Export actions into submenus.Sat, Dec 1, 8:26 PM
loh.tar added a subscriber: loh.tar.Tue, Dec 4, 3:19 PM

I like the approach to move much into a 2nd level menu because I'm easy annoyed by long menus where I have to scan and move a long way down.

... Save As... That one is super common and I think it deserves to be on the top level

It would be good to give new idea's a chance and not to cling to old fashioned ones only on principle.

Furthermore is it to me often confusing where to find some point, on 1st or 2nd level. So when all is in 2nd and 1st level is short (in height) and descriptive it could help to find faster what your are looking for.

However, it's even worse when you have more than two menu level or when the 1st level menu is to wide, as often in German where the translators seams to focus more on to be as accurate as possible rather than short as possible.

So my suggestion would be to have only "Save >", "Print and Export >", "Close >" and so forth on 1st level.