vtasoulas (Vangelis Tasoulas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 19 2016, 6:50 PM (164 w, 3 d)
Availability
Available

Recent Activity

Dec 12 2017

vtasoulas added inline comments to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
Dec 12 2017, 9:50 PM
vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

About the other skins, I can fix them once this patch gets merged.
The nice thing is that the old skins continue to work, however, no arrow buttons will be shown.
So yakuake will look like it used to, and scroll will only be working with the mouse wheel or shift+left/right.

Dec 12 2017, 7:22 AM

Dec 11 2017

vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

OK, suggestions incorporated and hopefully I will not mess up again with arc.

Dec 11 2017, 9:13 PM
vtasoulas updated the diff for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

Hopefully fixing the messed up previous commit.

Dec 11 2017, 9:12 PM
vtasoulas added inline comments to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
Dec 11 2017, 9:02 PM
vtasoulas updated the diff for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
  • Improvements as suggested by alexeymin.
Dec 11 2017, 9:01 PM

Dec 10 2017

vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

Done. Sorry again for the noise. Things should be working as expected now.

Dec 10 2017, 4:43 PM
vtasoulas updated the diff for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
  • Added tabbar scrolling support when the selected button cannot fit in the tabbar. Changed the way that the tabbar is getting drawn in order to support a scrollbar in the future. Now the buttons in the tabbar are all getting drawn in an off-screen private pixmap, called the buttonBar, and the buttonBar is getting scrolled as needed and painted to the widget at once.
  • Added scroll buttons in the tabbar.
  • Added support for the tabbar scroll buttons in the default (Breeze) theme.
  • Selecting the correct tabs for double click actions
Dec 10 2017, 4:25 PM
vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

Grrrr! I messed up completely the patch with the arc tool.
Please don't test until I fix it. I will ping again. Sorry for the noise.

Dec 10 2017, 4:09 PM
vtasoulas updated the diff for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
Dec 10 2017, 4:02 PM
vtasoulas updated the diff for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
Dec 10 2017, 3:59 PM
vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

@alexeymin Thank you for helping me find the problem (with your arc patch tip).

Dec 10 2017, 3:13 PM
vtasoulas updated the diff for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
  • Updated corrupted png files.
Dec 10 2017, 2:58 PM

Dec 1 2017

vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

@hein any possibility to get this merged? If not, any requested suggestions for improvements?

Dec 1 2017, 11:15 PM

Oct 27 2017

vtasoulas raised a concern with R369:3cdc1d0654dc: Fix (my) yakuake on a wayland session.

I can confirm that after this commit yakuake stays open when it is losing focus on X11.

Oct 27 2017, 12:00 AM

Oct 22 2017

vtasoulas added a comment to D7972: Scroll wheel and touchpad zoom in smaller increments.

@ngraham no worries about the authorship. You did at least as much for this patch, if not more when you include all the administrative work to get this patch landed :)

Oct 22 2017, 6:23 PM

Oct 10 2017

vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

Another thing that I paid attention with this implementation is to not break existing skins. @alexeymin, as you might have noticed (hopefully if everything worked as intended) even if you couldn't see the arrow buttons with your selected skin, the skin looked as it used to. Moreover, the scrolling works in old skins, e.g. by using the mouse wheel button, even if there are no clickable arrow buttons.

Oct 10 2017, 3:08 PM
vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

This is how the updated default skin should look like:

Oct 10 2017, 2:55 PM
vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

Are you sure that the updated default skin is used?

Oct 10 2017, 2:50 PM
vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

@hein since this is a quite large commit that adds a new feature, I guess it is you who should decide if the implementation is acceptable or needs any modifications.

Oct 10 2017, 2:16 PM
vtasoulas added a comment to D7813: Suppress yakuake "Unregister input type" warning when using qdbus.

I don't have commit access so someone else should do it for me :)

Oct 10 2017, 2:07 PM

Oct 8 2017

vtasoulas added a comment to D7972: Scroll wheel and touchpad zoom in smaller increments.

@ngraham yes, vangelis@tasoulas.net is my primary e-mail, but my KDE identity still uses the cyberang3l@gmail.com e-mail (which is still valid).

Oct 8 2017, 10:45 AM

Oct 7 2017

vtasoulas added a reviewer for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar.: alexeymin.
Oct 7 2017, 11:59 PM
vtasoulas added a comment to D7813: Suppress yakuake "Unregister input type" warning when using qdbus.

@hein is this patch acceptable now to be committed?

Oct 7 2017, 11:55 PM
vtasoulas updated the summary of D7813: Suppress yakuake "Unregister input type" warning when using qdbus.
Oct 7 2017, 11:55 PM
vtasoulas added a comment to D7972: Scroll wheel and touchpad zoom in smaller increments.

Yes, this is a valid email address that you can use. Thank you :)

Oct 7 2017, 11:49 PM
vtasoulas accepted D7972: Scroll wheel and touchpad zoom in smaller increments.
Oct 7 2017, 11:40 PM
vtasoulas requested changes to D7972: Scroll wheel and touchpad zoom in smaller increments.
Oct 7 2017, 11:31 PM

Oct 6 2017

vtasoulas added reviewers for D7972: Scroll wheel and touchpad zoom in smaller increments: lukas, gateau, rkflx.
Oct 6 2017, 9:17 PM
vtasoulas added a comment to D7972: Scroll wheel and touchpad zoom in smaller increments.

Is there any way to update the current diff?

Oct 6 2017, 9:10 PM
vtasoulas added a comment to D7972: Scroll wheel and touchpad zoom in smaller increments.

How about the following?
Implements the zoom as Inkscape and Krita does: for more than 100% the zoom is increased by sqrt(2); for less than 100% the zoom is decreased by sqrt(0.5).

Oct 6 2017, 9:02 PM

Sep 17 2017

vtasoulas added a comment to D7813: Suppress yakuake "Unregister input type" warning when using qdbus.

As long as the parameters of a function that is exposed via the QDBus interface are of a non-standard type such as int, QString etc, QDbus doesn't know how to handle them (kind of expected).
After some searching I believe that the correct way to handle such parameters is to register a new metatype for your special parameter and create marhalling/demarshalling functions as explained here: http://doc.qt.io/qt-5/qdbusargument.html#details
But this will need many more changes in the code.

Sep 17 2017, 8:54 PM

Sep 14 2017

vtasoulas updated the diff for D7813: Suppress yakuake "Unregister input type" warning when using qdbus.

Changed the commit to prevent breaking the existing DBus API based on the suggestions of @alexeymin.

Sep 14 2017, 11:06 PM
vtasoulas added a comment to D7812: Fixes a yakuake "index out of range" crash produced by QDBus exposed function TabBar::sessionAtTab(int).

@alexeymin yes, that's how it should be working.

Sep 14 2017, 9:56 PM
vtasoulas created D7813: Suppress yakuake "Unregister input type" warning when using qdbus.
Sep 14 2017, 11:12 AM
vtasoulas created D7812: Fixes a yakuake "index out of range" crash produced by QDBus exposed function TabBar::sessionAtTab(int).
Sep 14 2017, 9:47 AM

Sep 11 2017

vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

This quite large commit is broken in three commits in the repository here: https://github.com/cyberang3l/yakuake/tree/scroll-tabs

Sep 11 2017, 11:39 PM
vtasoulas updated the diff for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

Added scroll buttons in the tabbar as suggested by @alexeymin.
Added support for the tabbar scroll buttons in the default (Breeze) theme.

Sep 11 2017, 11:31 PM
vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

No, we don't have tabbar arrows at the moment.

Sep 11 2017, 8:50 AM

Sep 10 2017

vtasoulas added a comment to D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..

Yes, lots of code already so let's see if this gets accepted first.
Before scrollbar comes in the UI, I see two more steps:

Sep 10 2017, 10:10 PM
vtasoulas added a reviewer for D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar.: KDE Applications.
Sep 10 2017, 6:51 PM
vtasoulas added reviewers for D7731: Gwenview: suppressed unused interface variables compiler warnings.: gateau, lukas, KDE Applications, ngraham, aacid.
Sep 10 2017, 6:48 PM
vtasoulas updated the diff for D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF.

There was this conditional compilation with the following comment:

Sep 10 2017, 12:55 PM
vtasoulas added a comment to D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF.

Here is a link with two JPG photographs: https://www.dropbox.com/s/ec7gmoerq4xf95a/test_gwenview_importer.tar?dl=0

Sep 10 2017, 11:54 AM

Sep 9 2017

vtasoulas added a comment to D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF.

I shoot with a Nikon D300 which clock is configured (usually) to UTC+1.

Sep 9 2017, 11:36 PM
vtasoulas added a reviewer for D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF: ngraham.
Sep 9 2017, 8:39 PM

Sep 7 2017

vtasoulas added a reviewer for D7731: Gwenview: suppressed unused interface variables compiler warnings.: broulik.
Sep 7 2017, 10:50 PM
vtasoulas created D7731: Gwenview: suppressed unused interface variables compiler warnings..
Sep 7 2017, 10:49 PM
vtasoulas retitled D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar. from Added tabbar scrolling support when the selected button cannot fit in the tabbar. to Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
Sep 7 2017, 8:29 PM
vtasoulas created D7727: Bug 339139: Added tabbar scrolling support when the selected button cannot fit in the tabbar..
Sep 7 2017, 8:28 PM

Sep 1 2017

vtasoulas added a comment to D7636: Replaced calls to the deprecated function KJobUiDelegate *ui()..

No commit access. Feel free to commit the changes.

Sep 1 2017, 8:54 AM

Aug 31 2017

vtasoulas created D7636: Replaced calls to the deprecated function KJobUiDelegate *ui()..
Aug 31 2017, 7:32 PM
vtasoulas updated the diff for D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF.

Incorporated the changes suggested by Christoph Feck.

Aug 31 2017, 6:32 PM

Aug 15 2017

vtasoulas updated the diff for D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF.

In the first patch I had just changed the accepted parameter of the "Exiv2ImageLoader::load()" function from QByteArray& to QString.
But code that expects this function to accept a QByteArray exists in different parts of the software. In this updated patch I just added a second instance of the function "Exiv2ImageLoader::load()" without removing the original one.

Aug 15 2017, 9:53 AM
vtasoulas created D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF.
Aug 15 2017, 8:28 AM