Differential D300

DataSourceQueriesTest Porting to fake: shouldNotCrashDuringFindTopLevelWhenFetchJobFailedOrEmpty
ClosedPublic
Actions

Authored by franckarrecot on Aug 29 2015, 11:14 AM.

Details

Reviewers
bensi
ervin
remibenoit
Commits
R4:7f2e4e3e43b6: DataSourceQueriesTest Porting to fake…

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
franckarrecot updated this revision to Diff 650.Aug 29 2015, 11:14 AM
franckarrecot retitled this revision from to DataSourceQueriesTest Porting to fake: shouldNotCrashDuringFindTopLevelWhenFetchJobFailedOrEmpty.
franckarrecot updated this object.
franckarrecot edited the test plan for this revision. (Show Details)
franckarrecot added reviewers: ervin, bensi, remibenoit.
ervin accepted this revision.Sep 2 2015, 5:28 PM
ervin edited edge metadata.

I'm not a huge fan of the introduced storage, monitor and serializer variable but OK.

This revision is now accepted and ready to land.Sep 2 2015, 5:28 PM
franckarrecot updated this revision to Diff 714.Sep 5 2015, 11:47 AM
franckarrecot edited edge metadata.

up

franckarrecot added a comment.Sep 5 2015, 12:00 PM

nothing change here; no worry, my bad.

ervin requested changes to this revision.Sep 5 2015, 4:05 PM
ervin edited edge metadata.
ervin added inline comments.
tests/units/akonadi/akonadidatasourcequeriestest.cpp
535–541

Actually, since I'm pushing for sparing the unneeded local variables on the other patches... :-)

Please get rid of the storage, serializer and monitor local variables and pass them directly to the queries ctor like in the other tests.

This revision now requires changes to proceed.Sep 5 2015, 4:05 PM
franckarrecot updated this revision to Diff 743.Sep 5 2015, 7:25 PM
franckarrecot edited edge metadata.

o

ervin accepted this revision.Sep 5 2015, 8:53 PM
ervin edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2015, 8:53 PM
Closed by commit R4:7f2e4e3e43b6: DataSourceQueriesTest Porting to fake… (authored by franckarrecot). · Explain WhySep 7 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 798

View Options

tests/units/akonadi/akonadidatasourcequeriestest.cpp

Loading...