gateau (Aurélien Gâteau)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 5 2017, 7:19 PM (85 w, 2 d)
Availability
Available

Recent Activity

Sep 10 2018

gateau removed a reviewer for D15295: [konsole]: proper fix for a crash-on-exit: gateau.
Sep 10 2018, 8:06 PM · Konsole

Nov 5 2017

gateau accepted D8196: Try to keep ContextManager in sync with viewed files in MainWindow.

Small nitpick on a coding style issue, but the code looks good, thanks for your work!

Nov 5 2017, 8:06 PM

Oct 24 2017

gateau accepted D8423: Make CFitsio optional.

LGTM, but I agree you could get rid of fitsplugin.h in lib/CMakeLists.txt

Oct 24 2017, 4:01 PM

Oct 15 2017

gateau requested changes to D7972: Scroll wheel and touchpad zoom in smaller increments.

Some minor requests, but we are getting there!

Oct 15 2017, 11:19 AM
gateau accepted D8241: Fix zoom slider toolbuttons not disabling properly.
Oct 15 2017, 11:13 AM

Oct 7 2017

gateau requested changes to D7972: Scroll wheel and touchpad zoom in smaller increments.
Oct 7 2017, 8:33 AM

Sep 30 2017

gateau committed R375:62831768cdb3: Improve opacity handling (authored by gateau).
Improve opacity handling
Sep 30 2017, 12:26 PM
gateau closed D6655: Make sure ruler cannot be made completely transparent.
Sep 30 2017, 12:25 PM

Sep 27 2017

gateau added a comment to D7305: Add FITS format support.

I think the basic problem here that the static Qt plugin is put inside a shared library

Sep 27 2017, 5:24 PM

Sep 24 2017

gateau accepted D7305: Add FITS format support.

Why is this restricted to Linux? Does it work out of the box on Windows and macOS?

Sep 24 2017, 5:46 PM

Sep 10 2017

gateau added a comment to D7305: Add FITS format support.

The fits decoding is moved to imageformats as you requested.
I had huge problems with the static plugin registration, the old way did not work at all. I finally figured out a workaround hack, but I had to spend couple of hours on this. Explanation is written in app/CMakeLists.txt.

Sep 10 2017, 2:04 PM
gateau accepted D7317: Proposed patch to fix Bug 383520: Gwenview Importer doesn't use date/time from EXIF.

Looks good, thanks for simplifying exception handling code in Exiv2ImageLoader.

Sep 10 2017, 1:43 PM

Aug 20 2017

gateau requested changes to D7305: Add FITS format support.

Regarding kimageformats:

  • You don't need to provide write support: some formats are read-only (see README.md)
  • Adding fits format to kimageformats also means Dolphin and the file dialogs can show thumbnails for .fits files, maybe that could be useful?
  • It is true that you would have to duplicate some code to add metadata support in Gwenview. The right way to avoid that would be to create a Qt library to handle the fits image format and use it in kimageformats and Gwenview (and KStars maybe?). That's more work to do though, so I can understand if you don't want to go that way, but if you are already duplicating code from KStars to Gwenview to add fits support (I haven't checked if it is the case), then creating a library would make sense.
Aug 20 2017, 9:07 AM
gateau accepted D7288: Add ccache support.

OK, makes sense.

Aug 20 2017, 8:49 AM

Aug 15 2017

gateau added a comment to D7288: Add ccache support.

It works for me:

[perso ~/src/colorpick/build]
$ which gcc
/usr/lib/ccache/gcc
[perso ~/src/colorpick/build]
$ cmake -G Ninja ..
-- The C compiler identification is GNU 6.2.0
-- The CXX compiler identification is GNU 6.2.0
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/perso/src/colorpick/build
[perso ~/src/colorpick/build]
$ ccache -s
cache directory                     /home/perso/.ccache
primary config                      /home/perso/.ccache/ccache.conf
secondary config      (readonly)    /etc/ccache.conf
cache hit (direct)                   297
cache hit (preprocessed)              15
cache miss                          1390
called for link                     1126
called for preprocessing             167
multiple source files                  1
compile failed                        80
preprocessor error                     7
no input file                         64
files in cache                      1379
cache size                          39.5 MB
max cache size                       1.1 GB
[perso ~/src/colorpick/build]
$ ninja
[1/14] Automatic moc for target colorpick
Generating moc_coloreditor.cpp
Generating moc_colorpicker.cpp
Generating moc_componenteditor.cpp
Generating moc_contrastpreview.cpp
Generating moc_window.cpp
[14/14] Linking CXX executable src/colorpick
[perso ~/src/colorpick/build]
$ ccache -s
cache directory                     /home/perso/.ccache
primary config                      /home/perso/.ccache/ccache.conf
secondary config      (readonly)    /etc/ccache.conf
cache hit (direct)                   297
cache hit (preprocessed)              15
cache miss                          1401
called for link                     1127
called for preprocessing             167
multiple source files                  1
compile failed                        80
preprocessor error                     7
no input file                         64
files in cache                      1412
cache size                          40.0 MB
max cache size                       1.1 GB
Aug 15 2017, 10:18 AM
gateau requested changes to D7305: Add FITS format support.

Looks good, but I think it would be better if most of the work were in https://cgit.kde.org/kimageformats.git/ instead, unless it is not possible for some reason. Doing it that way would avoid adding a bunch of ifs in Gwenview, but more importantly, would bring support to fits format to all KDE applications. It might still be necessary to add some fits-specific code to show the meta information in Gwenview.

Aug 15 2017, 10:12 AM
gateau added a comment to D7288: Add ccache support.

Is this really necessary? Building with ccache is usually just a matter of making sure /usr/lib/ccache comes first in $PATH. Or am I missing something?

Aug 15 2017, 9:54 AM

Aug 8 2017

gateau committed R32:830f6deb50a8: Merge branch 'agateau/launchdialog-redesign' (authored by gateau).
Merge branch 'agateau/launchdialog-redesign'
Aug 8 2017, 4:16 PM
gateau committed R32:70fb836f652a: Simplify menu to remove 1-entry levels (authored by gateau).
Simplify menu to remove 1-entry levels
Aug 8 2017, 4:16 PM
gateau committed R32:88383f010e70: Adjust layout (authored by gateau).
Adjust layout
Aug 8 2017, 4:16 PM
gateau committed R32:685ceda2204c: put add/remove buttons below the list, use labels (authored by gateau).
put add/remove buttons below the list, use labels
Aug 8 2017, 4:16 PM
gateau committed R32:378ea4f926a1: Kill triple margin and redundant vertical line (authored by gateau).
Kill triple margin and redundant vertical line
Aug 8 2017, 4:16 PM
gateau committed R32:5914f88aa71b: Make it easier to reach buttons on the edges (authored by gateau).
Make it easier to reach buttons on the edges
Aug 8 2017, 4:16 PM
gateau committed R32:c2bb0fa5ccb9: Make area switcher usable when kdevelop runs on an appmenu-enabled system (authored by gateau).
Make area switcher usable when kdevelop runs on an appmenu-enabled system
Aug 8 2017, 4:16 PM

Jul 12 2017

gateau created D6655: Make sure ruler cannot be made completely transparent.
Jul 12 2017, 4:53 PM

Jul 2 2017

gateau closed D6285: New Alt+Arrow keys shortcuts for KRuler.

Merged in

Jul 2 2017, 8:01 AM
gateau committed R375:c0426f7df330: D6285 New Alt+Arrow keys shortcuts for KRuler (authored by gateau).
D6285 New Alt+Arrow keys shortcuts for KRuler
Jul 2 2017, 8:00 AM
gateau committed R375:1a4cd88a8d23: Document keyboard handling (authored by gateau).
Document keyboard handling
Jul 2 2017, 8:00 AM
gateau committed R375:e9367e12e6c2: Use alt+arrow keys to move the mouse cursor (authored by gateau).
Use alt+arrow keys to move the mouse cursor
Jul 2 2017, 8:00 AM
gateau accepted D6379: FIX Bug 362474 - Copy To/Move To does not remember path any more.

Looks good!

Jul 2 2017, 7:53 AM

Jun 24 2017

gateau added a comment to D6285: New Alt+Arrow keys shortcuts for KRuler.

Ping, do you think this can go in?

Jun 24 2017, 5:44 PM

Jun 21 2017

gateau added a comment to D6293: Make center action toggle between centered and regular.

Ah, I got stuck with that too! but I solved it in a different way: I merged the direction (left-to-right, right-to-left) and center origin concepts into 3 modes, which can be switched with F2, F3 and F4. You can build the work branch of my scratch repo (git@git.kde.org:clones/kruler/gateau/kruler) to give it a try.

Jun 21 2017, 4:57 PM
gateau added inline comments to D6285: New Alt+Arrow keys shortcuts for KRuler.
Jun 21 2017, 4:49 PM

Jun 19 2017

gateau created D6285: New Alt+Arrow keys shortcuts for KRuler.
Jun 19 2017, 9:21 PM

Jun 14 2017

gateau committed R375:1e4365721222: Merge review request 130152 (authored by gateau).
Merge review request 130152
Jun 14 2017, 5:38 PM
gateau committed R375:e0aa9d7bf7af: Add copyright (authored by gateau).
Add copyright
Jun 14 2017, 5:38 PM
gateau committed R375:3d723a3f5165: Update screenshot (authored by gateau).
Update screenshot
Jun 14 2017, 5:38 PM
gateau committed R375:7ac5b56f2b77: Remove doc of dropped features (authored by gateau).
Remove doc of dropped features
Jun 14 2017, 5:38 PM
gateau committed R375:04f886344b35: Make ticks not fully opaque (authored by gateau).
Make ticks not fully opaque
Jun 14 2017, 5:38 PM
gateau committed R375:6b370d75a3ac: Document how to resize the ruler (authored by gateau).
Document how to resize the ruler
Jun 14 2017, 5:38 PM
gateau committed R375:3855500a322a: Fix missing ticks at ends of ruler (authored by gateau).
Fix missing ticks at ends of ruler
Jun 14 2017, 5:38 PM
gateau committed R375:3f68e98f6f5a: Add indicator overlay (authored by gateau).
Add indicator overlay
Jun 14 2017, 5:38 PM
gateau committed R375:795a93b01edd: Remove display of ruler size (authored by gateau).
Remove display of ruler size
Jun 14 2017, 5:38 PM
gateau committed R375:934fd4db85ec: Use a red cross cursor (authored by gateau).
Use a red cross cursor
Jun 14 2017, 5:38 PM
gateau committed R375:31306680bcf1: Remove length actions (authored by gateau).
Remove length actions
Jun 14 2017, 5:38 PM
gateau committed R375:6f4f2a5cf02a: Make edges resizeable by drag'n'drop (authored by gateau).
Make edges resizeable by drag'n'drop
Jun 14 2017, 5:38 PM
gateau committed R375:c45b2957e134: Do not draw text under resize handles (authored by gateau).
Do not draw text under resize handles
Jun 14 2017, 5:38 PM
gateau committed R375:802902f2ac9e: Measure lengths, not positions (authored by gateau).
Measure lengths, not positions
Jun 14 2017, 5:38 PM
gateau committed R375:26a09f1fd82f: Draw ruler indicator (authored by gateau).
Draw ruler indicator
Jun 14 2017, 5:38 PM
gateau committed R375:933bad4f488c: Replace mOrientation with mHorizontal (authored by gateau).
Replace mOrientation with mHorizontal
Jun 14 2017, 5:38 PM
gateau committed R375:63f6bbe9dd5d: Remove buttons (authored by gateau).
Remove buttons
Jun 14 2017, 5:38 PM
gateau committed R375:00a461555fb6: Keep only one orientation action: Rotate (authored by gateau).
Keep only one orientation action: Rotate
Jun 14 2017, 5:38 PM
gateau committed R375:2908cb59585a: Center label, simplify cursors (authored by gateau).
Center label, simplify cursors
Jun 14 2017, 5:38 PM
gateau committed R375:9abd51b51a65: Factorize tick and text drawing code (authored by gateau).
Factorize tick and text drawing code
Jun 14 2017, 5:38 PM
gateau committed R375:fc32dd446876: Remove color picker (authored by gateau).
Remove color picker
Jun 14 2017, 5:38 PM
gateau committed R375:df4999a12229: Draw scale ticks on both sides of the ruler (authored by gateau).
Draw scale ticks on both sides of the ruler
Jun 14 2017, 5:38 PM
gateau committed R375:e2e1ec5ccbba: Fix overlapping texts (authored by gateau).
Fix overlapping texts
Jun 14 2017, 5:38 PM

Jun 6 2017

gateau added a comment to D6083: Bump max thumbnail size to 512px.

I love the idea, but what about caching? Cached thumbnails are supposed to follow https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html#THUMBSIZE, which still, sadly, says 256.

Jun 6 2017, 11:56 AM · Gwenview

Jun 3 2017

gateau accepted D5824: Fix Enter and Escape keys in tool dialogs (crop, red eye).

Looks good!

Jun 3 2017, 1:56 PM

May 28 2017

gateau added a comment to D5824: Fix Enter and Escape keys in tool dialogs (crop, red eye).

Ah yes, using keyPressEvent() sounds like a good idea.

May 28 2017, 8:05 PM

May 14 2017

gateau added a comment to D5749: Avoid data loss when importing pictures.

Thanks a lot for fixing the mess I created. I just added a note about this to the article on my blog.

May 14 2017, 8:32 PM
gateau requested changes to D5824: Fix Enter and Escape keys in tool dialogs (crop, red eye).
May 14 2017, 8:09 PM
gateau accepted D5752: Port more deprecated functions and fix warnings.
May 14 2017, 8:01 PM

Mar 27 2017

gateau committed R260:3e10699ac37c: Add Fit to width (authored by Eldin Gagulić <dino.gaguliceldin@gmail.com>).
Add Fit to width
Mar 27 2017, 6:16 AM