- User Since
- Jul 20 2019, 6:06 AM (54 w, 3 d)
Wed, Jul 29
Added the context menu code.
Thu, Jul 23
Hi all, if it's ok for me to weigh in on this a bit, I will say firstly that I love kate/kwrite, and was immediately blown away by both when I (finally) discovered them recently.
Sat, Jul 18
I agree about the cruft, and I highly recommend against shipping two home desktop files. As I have it now, it's just one extra line in two files, which an administrator could edit, or copy, if so motivated. At least on FC30, the kio plugin for fonts:/ is included in a package separate to konqueror (plasma_desktop, if I remember correctly), so someone could theoretically just create packages for sidebar buttons they want to have on their system, and use the current button .desktop files for reference. It's what falkon is doing for themes, for example.
Ahh, that would definitely be an interesting approach. Would you be opposed to having what is currently done incorporated now? I can't allocate time to implement your approach, or think of use cases where someone might want to choose one over the other (or potential problems with your approach), but at least with this we can have the option in there. For sure a context menu toggle would avoid any potential issues there could be (I have tons of old hidden folders in my home directory for example, I wouldn't always want it showing or toggling automatically on).
Tue, Jul 14
Mon, Jul 13
Jun 15 2020
May 11 2020
I just found this unsubmitted comment, not sure what happened, but I figured it would be useful information to pass along anyway. (I somehow managed to work around it a month ago, without compiling ECM):
Apr 15 2020
Eighth revision of the konq sidebar code. After review.
Seventh revision of the konq sidebar code. After review.
By the way, this prevents compilation of the not-yet-committed sidebar panel code. Specifically, the sidebar/web_module/web_module.cpp
Apr 10 2020
Seventh revision, after review (minor edit)
Seventh revision, after review
Apr 9 2020
Sixth version, after review, fixing rebase(?)
Apr 8 2020
- Sixth revision of the konq sidebar code. After review
Apr 6 2020
Is there a temporary workaround for people who cannot yet upgrade to 5.68? Something we could wrap in something like
Apr 5 2020
Getting a CMake error on plugins/fsview/CMakeLists.txt line 16 (ecm_qt_declare_logging_category). Fedora 30, i686, KF5 5.64.
Apr 2 2020
Mar 28 2020
Tested, no crashes, it works as intended, and it is beautiful! Thank you!
Mar 25 2020
Hi, sorry for the lack of responses, for some reason I did not receive any of the notifications except this last one. I will test and comment as soon as I can. Wishing everyone safety and health too.
Mar 1 2020
kf5.kio.kdirmodel: Items emitted in directory QUrl("file:///home/myuser/") but that directory isn't in KDirModel! Root directory: QUrl("file:///home/myuser/") KCrash: Application 'konqueror' crashing...
Feb 28 2020
Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL.
KDirModel takes care of that.
Ok, I found one of the "implications". With model->dirLister()->openUrl(m_initURL, KDirLister::Keep); I can list KIO urls like remote:, font:, and applications:, but with model->openUrl(m_initURL, KDirModel::ShowRoot); I cannot, and only seems to display the the local filesystem (specifically it lists "/"). I can probably work around it, but just wanted to pass that info along. I think it would be great if the "root" could be shown for these as well.
Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally:
Feb 11 2020
https://invent.kde.org/kde/kate/commit/54b3fd74f74f604932b93f46aeaba4e8f5e9a2aa works as intended! Thanks!
Feb 6 2020
I agree that sorting needs to be improved, however I don't have the skills right now (or time) to implement them.
Ideally the number of open files should sort numerically, and the last opened should sort via timestamp, to allow for locale-based display. But both of these require the same intrinsic change that I don't know how to do yet (the class is chosen by the .ui file, and a new overloaded class with the proper sorting functions would need to be implemented). But with this first set of changes in this patch we can get something out there for people to use now. Someone else might come later to do that, just as I did for this part.
As requested. You will notice that the button to sort has been removed and sorting is done only by clicking the header bars.
Feb 5 2020
Jan 17 2020
Implemented the changes suggested by dfaure.
Jan 14 2020
Jan 12 2020
Jul 25 2019
Done! I submitted the merge via https://invent.kde.org/kde/konsole/merge_requests/19