rrosch (Raphael Rosch)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 20 2019, 6:06 AM (54 w, 3 d)
Availability
Available

Recent Activity

Wed, Jul 29

rrosch updated the test plan for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Wed, Jul 29, 7:53 AM · Documentation
rrosch updated the diff for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Added the context menu code.

Wed, Jul 29, 7:48 AM · Documentation

Thu, Jul 23

rrosch added a comment to T10243: Some KDE applications could use better icons.

Hi all, if it's ok for me to weigh in on this a bit, I will say firstly that I love kate/kwrite, and was immediately blown away by both when I (finally) discovered them recently.

Thu, Jul 23, 2:47 AM · KDE Applications, VDG

Sat, Jul 18

rrosch added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

I agree about the cruft, and I highly recommend against shipping two home desktop files. As I have it now, it's just one extra line in two files, which an administrator could edit, or copy, if so motivated. At least on FC30, the kio plugin for fonts:/ is included in a package separate to konqueror (plasma_desktop, if I remember correctly), so someone could theoretically just create packages for sidebar buttons they want to have on their system, and use the current button .desktop files for reference. It's what falkon is doing for themes, for example.

Sat, Jul 18, 11:24 PM · Documentation
rrosch added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Ahh, that would definitely be an interesting approach. Would you be opposed to having what is currently done incorporated now? I can't allocate time to implement your approach, or think of use cases where someone might want to choose one over the other (or potential problems with your approach), but at least with this we can have the option in there. For sure a context menu toggle would avoid any potential issues there could be (I have tons of old hidden folders in my home directory for example, I wouldn't always want it showing or toggling automatically on).

Sat, Jul 18, 8:16 PM · Documentation

Tue, Jul 14

rrosch added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

The commit log explains the what but not the why. Can you give more details about the use case for this? At first sight it smells like overconfigurability (given that the user can already request that hidden files are shown, more globally).

Tue, Jul 14, 1:13 PM · Documentation

Mon, Jul 13

rrosch retitled D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display) from Enable option to hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display) to Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Mon, Jul 13, 3:21 PM · Documentation
rrosch requested review of D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Mon, Jul 13, 3:18 PM · Documentation

Jun 15 2020

rrosch committed R319:a9c892ad4627: Update index.docbook changes for Bourne prompt sigil to read more clearly (authored by rrosch).
Update index.docbook changes for Bourne prompt sigil to read more clearly
Jun 15 2020, 3:54 AM
rrosch committed R319:2fb90d2de7e1: Merge branch 'master' of invent.kde.org:rrosch/konsole (authored by rrosch).
Merge branch 'master' of invent.kde.org:rrosch/konsole
Jun 15 2020, 3:54 AM
rrosch committed R319:296d8253722f: Merge branch 'master' into 'master' (authored by rrosch).
Merge branch 'master' into 'master'
Jun 15 2020, 3:54 AM
rrosch committed R319:df6397754163: Merge branch 'master' of invent.kde.org:rrosch/konsole (authored by rrosch).
Merge branch 'master' of invent.kde.org:rrosch/konsole
Jun 15 2020, 3:53 AM
rrosch committed R319:0728d33e07b2: Tweak tab title options: home and Bourne prompt sigils (authored by rrosch).
Tweak tab title options: home and Bourne prompt sigils
Jun 15 2020, 3:53 AM
rrosch committed R319:e8a60e6b778f: Update index.docbook changes for Bourne prompt sigil to read more clearly (authored by rrosch).
Update index.docbook changes for Bourne prompt sigil to read more clearly
Jun 15 2020, 3:53 AM
rrosch committed R319:9ea3eb181343: Tweak tab title options: home and Bourne prompt sigils (authored by rrosch).
Tweak tab title options: home and Bourne prompt sigils
Jun 15 2020, 3:53 AM
rrosch committed R319:95f338bab0e1: Tweak tab title options: home and Bourne prompt sigils (authored by rrosch).
Tweak tab title options: home and Bourne prompt sigils
Jun 15 2020, 3:53 AM

May 11 2020

rrosch added a comment to D28486: File Size View: Port away from KDElibs4Support.

I just found this unsubmitted comment, not sure what happened, but I figured it would be useful information to pass along anyway. (I somehow managed to work around it a month ago, without compiling ECM):

May 11 2020, 8:17 PM

Apr 15 2020

rrosch updated the diff for D28527: Fifth revision of the konq sidebar code..

Eighth revision of the konq sidebar code. After review.

Apr 15 2020, 1:14 PM
rrosch updated the diff for D28527: Fifth revision of the konq sidebar code..

Seventh revision of the konq sidebar code. After review.

Apr 15 2020, 8:21 AM
rrosch added a comment to D26471: Don't find KHTML.

By the way, this prevents compilation of the not-yet-committed sidebar panel code. Specifically, the sidebar/web_module/web_module.cpp

Apr 15 2020, 7:00 AM

Apr 10 2020

rrosch added inline comments to D28527: Fifth revision of the konq sidebar code..
Apr 10 2020, 10:37 AM
rrosch updated the diff for D28527: Fifth revision of the konq sidebar code..

Seventh revision, after review (minor edit)

Apr 10 2020, 10:36 AM
rrosch abandoned D28720: Seventh revision of the konq sidebar code. After review.
Apr 10 2020, 10:27 AM
rrosch updated the diff for D28527: Fifth revision of the konq sidebar code..

Seventh revision, after review

Apr 10 2020, 10:27 AM
rrosch requested review of D28720: Seventh revision of the konq sidebar code. After review.
Apr 10 2020, 10:24 AM
rrosch added inline comments to D28527: Fifth revision of the konq sidebar code..
Apr 10 2020, 10:15 AM

Apr 9 2020

rrosch updated the diff for D28527: Fifth revision of the konq sidebar code..

Sixth version, after review, fixing rebase(?)

Apr 9 2020, 5:49 PM

Apr 8 2020

rrosch updated the diff for D28527: Fifth revision of the konq sidebar code..
  • Sixth revision of the konq sidebar code. After review
Apr 8 2020, 10:26 PM

Apr 6 2020

rrosch added inline comments to D28527: Fifth revision of the konq sidebar code..
Apr 6 2020, 2:35 AM
rrosch added a comment to D28486: File Size View: Port away from KDElibs4Support.

Is there a temporary workaround for people who cannot yet upgrade to 5.68? Something we could wrap in something like

Apr 6 2020, 1:11 AM

Apr 5 2020

rrosch added a comment to D28486: File Size View: Port away from KDElibs4Support.

Getting a CMake error on plugins/fsview/CMakeLists.txt line 16 (ecm_qt_declare_logging_category). Fedora 30, i686, KF5 5.64.

Apr 5 2020, 4:38 AM

Apr 2 2020

rrosch added inline comments to D28527: Fifth revision of the konq sidebar code..
Apr 2 2020, 11:07 PM
rrosch requested review of D28527: Fifth revision of the konq sidebar code..
Apr 2 2020, 10:44 PM

Mar 28 2020

rrosch added a comment to D25315: KDirModel: implement showing a root node for the requested URL.

Tested, no crashes, it works as intended, and it is beautiful! Thank you!

Mar 28 2020, 4:40 AM · Frameworks

Mar 25 2020

rrosch added a comment to D25315: KDirModel: implement showing a root node for the requested URL.

Hi, sorry for the lack of responses, for some reason I did not receive any of the notifications except this last one. I will test and comment as soon as I can. Wishing everyone safety and health too.

Mar 25 2020, 12:54 AM · Frameworks

Mar 1 2020

rrosch added a comment to D25315: KDirModel: implement showing a root node for the requested URL.
kf5.kio.kdirmodel: Items emitted in directory QUrl("file:///home/myuser/") but that directory isn't in KDirModel! Root directory: QUrl("file:///home/myuser/")
KCrash: Application 'konqueror' crashing...
Mar 1 2020, 12:20 AM · Frameworks

Feb 28 2020

rrosch added a comment to D25315: KDirModel: implement showing a root node for the requested URL.

Keep only matters for further calls to openUrl, not the first one. It's about whether to *add* or *replace* the currently open URL.
KDirModel takes care of that.

Feb 28 2020, 9:30 PM · Frameworks
rrosch accepted D27731: Improve KDirModel to avoid showing '+' if there are no subdirs.
Feb 28 2020, 9:08 PM · Frameworks
rrosch added a comment to D25315: KDirModel: implement showing a root node for the requested URL.

Ok, I found one of the "implications". With model->dirLister()->openUrl(m_initURL, KDirLister::Keep); I can list KIO urls like remote:, font:, and applications:, but with model->openUrl(m_initURL, KDirModel::ShowRoot); I cannot, and only seems to display the the local filesystem (specifically it lists "/"). I can probably work around it, but just wanted to pass that info along. I think it would be great if the "root" could be shown for these as well.

Feb 28 2020, 12:37 PM · Frameworks
rrosch added a comment to D25315: KDirModel: implement showing a root node for the requested URL.

Tested on patched KF5 5.64, on Fedora 30 (32bit)... root node shows up! I had to change the call in my code that was originally:

Feb 28 2020, 12:22 PM · Frameworks

Feb 11 2020

rrosch added a comment to D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

Patch at
https://invent.kde.org/kde/kate/commit/54b3fd74f74f604932b93f46aeaba4e8f5e9a2aa works as intended! Thanks!

Feb 11 2020, 10:56 PM · Kate

Feb 6 2020

rrosch added a comment to D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

I agree that sorting needs to be improved, however I don't have the skills right now (or time) to implement them.
Ideally the number of open files should sort numerically, and the last opened should sort via timestamp, to allow for locale-based display. But both of these require the same intrinsic change that I don't know how to do yet (the class is chosen by the .ui file, and a new overloaded class with the proper sorting functions would need to be implemented). But with this first set of changes in this patch we can get something out there for people to use now. Someone else might come later to do that, just as I did for this part.

Feb 6 2020, 11:12 PM · Kate
rrosch added a comment to D27180: Add sortable columns to session manager dialog, and remove previous sorting code.

As requested. You will notice that the button to sort has been removed and sorting is done only by clicking the header bars.

Feb 6 2020, 9:55 PM · Kate

Feb 5 2020

rrosch added reviewers for D27180: Add sortable columns to session manager dialog, and remove previous sorting code: dhaumann, cullmann.
Feb 5 2020, 9:58 PM · Kate
rrosch requested review of D27180: Add sortable columns to session manager dialog, and remove previous sorting code.
Feb 5 2020, 9:57 PM · Kate

Jan 17 2020

rrosch updated the diff for D26647: Fix for window icon being stretched (and ugly) when window switcher uses large icons.

Implemented the changes suggested by dfaure.

Jan 17 2020, 2:23 AM · Konqueror

Jan 14 2020

rrosch requested review of D26647: Fix for window icon being stretched (and ugly) when window switcher uses large icons.
Jan 14 2020, 12:48 AM · Konqueror

Jan 12 2020

rrosch added a watcher for Kate: rrosch.
Jan 12 2020, 4:02 AM

Jul 25 2019

rrosch abandoned D22669: Tweak tab title options: home and Bourne prompt sigils.

Done! I submitted the merge via https://invent.kde.org/kde/konsole/merge_requests/19

Jul 25 2019, 2:27 AM · Documentation, Konsole

Jul 23 2019

rrosch added a reviewer for D22669: Tweak tab title options: home and Bourne prompt sigils: Konsole.
Jul 23 2019, 12:50 AM · Documentation, Konsole
rrosch requested review of D22669: Tweak tab title options: home and Bourne prompt sigils.
Jul 23 2019, 12:46 AM · Documentation, Konsole

Jul 20 2019

rrosch added a member for Konqueror: rrosch.
Jul 20 2019, 6:32 AM
rrosch added a watcher for Konqueror: rrosch.
Jul 20 2019, 6:31 AM