Differential D27731

Improve KDirModel to avoid showing '+' if there are no subdirs
ClosedPublic
Actions

Authored by dfaure on Feb 28 2020, 9:02 PM.

Details

Reviewers
apol
ahmadsamir
meven
rrosch
Commits
R241:ebe7714300af: Improve KDirModel to avoid showing '+' if there are no subdirs
Summary

We either have the information at hand (in populated dirs)
or we query the filesystem (in non-populated dirs).

Test Plan

Tested by Raphael Rosch in D25315

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23077
Build 23095: arc lint + arc unit
dfaure created this revision.Feb 28 2020, 9:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 28 2020, 9:02 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Feb 28 2020, 9:02 PM
rrosch accepted this revision.Feb 28 2020, 9:08 PM
This revision is now accepted and ready to land.Feb 28 2020, 9:08 PM
dfaure closed this revision.Feb 29 2020, 2:10 PM
meven added a comment.May 23 2020, 5:10 PM

I believe this causes https://bugs.kde.org/show_bug.cgi?id=419434
It causes similar issue with dolphin and KFileWidget

This is not a correct behavior.
It prevents file treeview to show files within folders with no subfolders.
The bug has a proposed patch :
https://bugsfiles.kde.org/attachment.cgi?id=128272

I think this needs to be reverted or at least reworked.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kdirmodel.cpp (17 lines)

Diff 76662

View Options

src/widgets/kdirmodel.cpp

Loading...