Differential D26471

Don't find KHTML
ClosedPublic
Actions

Authored by nicolasfella on Jan 6 2020, 4:08 PM.

Details

Reviewers
dfaure
vkrause
Group Reviewers
Konqueror
Maniphest Tasks
T11543: Port Konqueror away from KHTML
Commits
R226:430c4c9f411c: Don't find KHTML
Summary

It isn't linked any more

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Jan 6 2020, 4:08 PM
nicolasfella created this revision.
nicolasfella edited the summary of this revision. (Show Details)Jan 6 2020, 4:08 PM
nicolasfella added reviewers: Konqueror, dfaure.
nicolasfella retitled this revision from Remove last trace of KHTML to Don't find KHTML.Jan 6 2020, 4:10 PM
nicolasfella edited the summary of this revision. (Show Details)
nicolasfella added a task: T11543: Port Konqueror away from KHTML.
vkrause accepted this revision.Jan 6 2020, 5:40 PM
vkrause added a subscriber: vkrause.

Nice! I missed the about page got ported meanwhile :)

This revision is now accepted and ready to land.Jan 6 2020, 5:40 PM
dfaure accepted this revision.Jan 6 2020, 6:30 PM

Yep, this happened in D26253 :-)

Closed by commit R226:430c4c9f411c: Don't find KHTML (authored by nicolasfella). · Explain WhyJan 6 2020, 6:45 PM
This revision was automatically updated to reflect the committed changes.
rrosch added a subscriber: rrosch.EditedApr 15 2020, 7:00 AM

By the way, this prevents compilation of the not-yet-committed sidebar panel code. Specifically, the sidebar/web_module/web_module.cpp

https://phabricator.kde.org/D28527

(so for now, I will just be commenting out the add_subdirectory( web_module ) line in the sidebar/CMakeLists.txt, but it will need to be ported away from KHtml at some point, unless we don't mind the code being abandoned)

dfaure added a comment.Apr 18 2020, 2:42 PM

I don't mind if web_module dies out, it seems to be of very little practical use [a web page that automatically reloads, AFAICS].

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 72912

View Options

CMakeLists.txt

Loading...