@drosca can you check this once.

keyword gets updated in the bookmark widget and organize bookmarks.

In D28661#644983, @SGOrava wrote:

The other thing is:
This popup window can recognize if the site is already bookmarked or not.
In case it is already bookmarked it would be good to display keywords in keyword field.

fix the size of bookmark widget.

Update Placeholder

@SGOrava can you please review this.

@drosca sorry for the delay.

remove redundant code and add fill for email.

it looks if there is no name tag specified in the input tag, then we need to look for placeholder and I am filling the first part of the vector to username and the second to password.
anyways I will update the patch now.

@SGOrava @drosca is this good.

@drosca it's building and working for me,
and I changed the files according to your suggestions

@SGOrava @drosca can you check this please.

@drosca @SGOrava is there anything else I could do.

add translator and change name of function.

@SGOrava done. This is what you suggested right.

show notification only once.

@SGOrava with the changes that I did now, the user gets a notification only when he clicks "remember", "update" etc right. I which case he will get only one notification.

fix space issue.

fix space issue

done @SGOrava , is this fine.

remove QMessagebox and use desktop notifications to show notification

I actually didn't know what to use exactly and I thought that by using a message box we can also make the user click the close button in which there is a high probability that he will read. the message.

@alukichev done.

created a function for showing the prompt, the previous one was full of unwanted lines

@alukichev sorry, I know this is a bad mistake, will change asap and not repeat it again.
Thanks :)

@SGOrava is this fine.

Sorry for making the previous patch a redundant one, I hope this one fixes the issue when KWallet is disabled,
when KWallet is disabled and password is tried to save falkon prompts the user to enable KWallet.

sorry for this, even I thought the same but since it was discussed that it was better than nothing, I did this, if this is not good I am happy with that too.
can I close this, or do you suggest any changes?

remove unnecessary warning and clear white space issues.

SGOrava, changes are made in all the functions described.

updated the given functions to check for the m_wallet instance.

@SGOrava can you please review this.

add new line.

updated with the suggested changes.

add return and condition to check m_wallet

@mgallien I would like to work on this issue if proper guidelines are given where to start.

I am afraid I couldn't reproduce the issue, actually the minimum window size is fixed(with playlist bar visible) and I can't minimize it further to see if the playlist bar is missing.
Is there anything more I should do to reproduce this issue.

@mgallien @ngraham Can you please look into this https://invent.kde.org/kde/elisa/merge_requests/56

Hello @ngraham ,
I tried using that but the property change is not getting recognised, can you help me to get where the tracks change can be figured out

I was able to do this for adding the animations for the remainingTracks label

PropertyAction {
    target: remainingTracksLabel; property: "text"
    onPropertyChanged:
        ColorAnimation {
        from: "white"
        to: "black"
        duration: 200
    }
}

Can I please know if this is how it sould be done.

can I have the documentation for elisa, I couldn't find it anywhere

Hello, I am new to this community, I have made some simple applications using Qt.
I would really like to try out this issue if anyone else is not working on it.