Add Playlist button to the left panel
Closed, ResolvedPublic

Description

Currently when the window size is small enough, the playlist is hidden and there is no way to show it without resizing the window. There should be a Playlist button in the left panel to do that.

trmdi created this task.Dec 24 2019, 4:38 AM

I think the right way forward here is to port the Playlist to be a Kirigami Context Drawer. Then it will be simple to have it auto-show for certain window widths, and for narrower window widths, it will become a collapsible drawer rather than hiding entirely.

I am afraid I couldn't reproduce the issue, actually the minimum window size is fixed(with playlist bar visible) and I can't minimize it further to see if the playlist bar is missing.
Is there anything more I should do to reproduce this issue.

You need to build Elisa from source. The playlist auto-hiding feature was just added about a week ago; it's not included in any released versions. Generally when developing or sending patches, you should always be working with the code from the master branch in git.

bayang added a subscriber: bayang.EditedJul 11 2020, 3:30 PM

I'm having a look at this if everyone is ok.
I started following the kirigami drawer idea using the states browsingViewsNoPlaylist and browsingViews defined in ContentView.qml.
When in the browsingViews state, keep the current layout.
When in browsingViewsNoPlaylist state, currently the playlist disappears and is no longer visible, I juste added a drawer that is enabled only in this state.
I made a quick video to show what it currently looks like (attachment).
If this direction is ok for everyone, I will continue working on this.

Actually I decided to keep going, I added a second video to show what it looks like now (I think it is somewhat ok now).
The code is there
https://invent.kde.org/bayang/elisa/-/commit/0f6b342ae26a1c798346450b3e9760ddb067d201

That looks fantastic! Are you using real Kirigami components or just emulating the style?

It is a real Kirigami drawer.
But in order to use this, I changed ElisaMainWindow.qml from a standard Qt ApplicationWindow to a Kirigami.ApplicationWindow.
That might have side effects that I am not aware of :/

That's probably fine. It's something we needed to do eventually anyway. Submit the MR and we'll take a look. Thanks again!

chirag added a subscriber: chirag.Sep 21 2020, 10:55 AM

is this issue currently open as I can see the feature is already added in ELISA

ngraham closed this task as Resolved.Sep 21 2020, 2:16 PM
ngraham claimed this task.

Indeed, this was already implemented. :) If you're looking for ideas, there are a few more on the workboard, and here are a few more I think would be useful:

Better support for user-defined playlists
https://bugs.kde.org/show_bug.cgi?id=406477

Automatically fetch lyrics from the internet for songs without a Lyrics tag
https://bugs.kde.org/show_bug.cgi?id=406568

Provide a way to edit metadata from within Elisa
https://bugs.kde.org/show_bug.cgi?id=406472

The user should be able to define what double-clicking on a song does: play or enqueue?
https://bugs.kde.org/show_bug.cgi?id=406469

Provide way to find a given song in the filesystem
https://bugs.kde.org/show_bug.cgi?id=406471

Support Drag-and-drop from main content view to playlist
https://bugs.kde.org/show_bug.cgi?id=415207

Automatically enqueue the following songs when selecting & playing a song from the main view
https://bugs.kde.org/show_bug.cgi?id=417610


Oh and by the way, welcome to Elisa!