In D26932#601142, @puneethchanda wrote:

Sorry for making the previous patch a redundant one, I hope this one fixes the issue when KWallet is disabled,
when KWallet is disabled and password is tried to save falkon prompts the user to enable KWallet.

In D26753#598297, @SGOrava wrote:

I would need your name and email which I can use to commit it for you.
(I can guess, but I want to be sure)

SGOrava added a comment. View Revision
Do you have commit / push rights ?

No, I don't.

In D26753#598264, @SGOrava wrote:

OK, works almost fine, only the checkbox disabled state is not triggered at the first launch of preferences dialog.

Changes v3->v4:

• fixed initializing the new checkbox's enabled state upon Preferences construction.

In D26753#598233, @alukichev wrote:

In D26753#598232, @SGOrava wrote:

It can be:

• the direct relationship as I said before, we can also think of renaming the pepper plugins option

I think, "Allow Pepper Plugins" reflects it quite adequately, why the need to rename?

Changes v2->v3 (suggested by Juraj Oravec):

• renamed "Allow Pepper Plugins (Flash plugin)" checkbox to "Enable Pepper plugin API (PPAPI)";
• added "(requires PPAPI)" to the new checkbox's text;
• moved the new checkbox directly under "Pepper plugin API".

In D26753#598232, @SGOrava wrote:

It can be:

• the direct relationship as I said before, we can also think of renaming the pepper plugins option

Relationship is now relected by the new checkbox's "enabled/disabled" state, so - done. I think, "Allow Pepper Plugins" reflects it quite adequately, why the need to rename?

Changes v1->v2:

• made the checkbox's "enabled" property value depend on whether pepper plugins are enabled, because of noticed dependency, as suggested by Juraj Oravec.

In D26753#597754, @SGOrava wrote:

So I tested it and it works as intended.

In D26753#596709, @SGOrava wrote:

It should be optional, many people would like to have internal PDF viewer.

In D26753#596575, @SGOrava wrote:

It can be disabled by unchecking simple checkbox at:
(Preferences > Browsing > [ ] Allow Pepper Pluginf (Flash player)).