Differential D28661

Enable user to add keywords when saving bookmarks
Needs ReviewPublic
Actions

Authored by puneethchanda on Apr 7 2020, 4:32 PM.

Details

Reviewers
SGOrava
Summary

This patch allows the user to add keywords when he/she wants to save a bookmark and this keyword can be used to search them in organise bookmarks in preferences

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
puneethchanda created this revision.Apr 7 2020, 4:32 PM
Restricted Application added a subscriber: falkon. · View Herald TranscriptApr 7 2020, 4:32 PM
puneethchanda requested review of this revision.Apr 7 2020, 4:32 PM
SGOrava added inline comments.Apr 7 2020, 6:25 PM
src/lib/bookmarks/bookmarkswidget.ui
50

Use "Keyword" only because that is what is used in other places.

puneethchanda updated this revision to Diff 79723.Apr 9 2020, 5:16 PM

Update Placeholder

SGOrava added a comment.Apr 9 2020, 5:41 PM

The other thing is:
This popup window can recognize if the site is already bookmarked or not.
In case it is already bookmarked it would be good to display keywords in keyword field.

src/lib/bookmarks/bookmarkswidget.ui
53

Use "Keyword" only because that is what is used in other places.

puneethchanda updated this revision to Diff 79724.Apr 9 2020, 5:44 PM

fix the size of bookmark widget.

puneethchanda added a comment.Apr 9 2020, 5:45 PM
In D28661#644983, @SGOrava wrote:

The other thing is:
This popup window can recognize if the site is already bookmarked or not.
In case it is already bookmarked it would be good to display keywords in keyword field.

okay will work on it.

puneethchanda updated this revision to Diff 79885.Apr 11 2020, 9:26 PM

keyword gets updated in the bookmark widget and organize bookmarks.

Revision Contents
Changeset List

Diff 79885

View Options

src/lib/bookmarks/bookmarkswidget.cpp

Loading...
View Options

src/lib/bookmarks/bookmarkswidget.ui

Loading...