• Fix transparency of home icon in go.svgz

• Fix stylesheet in go.svgz

In D15999#369135, @ndavis wrote:

In D15999#369134, @pstefan wrote:

In D15999#369132, @ndavis wrote:

In D15999#369131, @pstefan wrote:

In D15999#369066, @ndavis wrote:

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |

Why would the ring and the background have different colors? They both have the same class attribute.

I must have had a slightly older version of the patch because I swear I saw the ring using ViewBackground and the background using Background. I downloaded the patch again and everything looks fine there. go.svgz still has #31363b and #232629 as the default colors for the background and ring. Is this intentional?

They do not have a default color for me.

Here's what I'm seeing:

In D15999#369132, @ndavis wrote:

In D15999#369131, @pstefan wrote:

In D15999#369066, @ndavis wrote:

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |

Why would the ring and the background have different colors? They both have the same class attribute.

I must have had a slightly older version of the patch because I swear I saw the ring using ViewBackground and the background using Background. I downloaded the patch again and everything looks fine there. go.svgz still has #31363b and #232629 as the default colors for the background and ring. Is this intentional?

In D15999#369066, @ndavis wrote:

With colorschemes applied, these will be your colors:

            | Ring    | Background | Symbol  |
            | ------- | ---------- | ------- |
     Breeze | #fcfcfc | #eff0f1    | #232627 |
Breeze Dark | #232629 | #31363b    | #eff0f1 |

• Remove hardcoded background color; Switch background to "ColorScheme-ViewBackground"
• Reintroduce the outline border on top of the background. Opacity set to 0.3
• Removed superfluous entries in the style properties

In D15999#368499, @filipf wrote:

In D15999#368498, @ngraham wrote:

In D15999#368479, @ndavis wrote:

It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the ColorScheme-Text class and the inner symbols should use the ColorScheme-Background class.

The opposite: the background is supposed to be dark with breeze dark, and light with breeze light.

In general, with dark themes you want white monochrome icons and the circle is now the dominant icon element, meaning it should get painted white.

But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark:

They would be weird looking and would be superfluous.

In the case of the SDDM theme I agree it's odd that the circles are colored differently than the input box, but the logout screen is more important.

• Hardcoded background color

• Fixed z order

• Added missing class attributes

• Sized down icons somewhat
• Added "*-translucent" option of the icons in go.svgz (go-home, go-previous, etc). 32px only for now
• Made background darker
• Removed outer circle
• Merge branch 'master' of git://anongit.kde.org/plasma-framework

In D15999#338724, @filipf wrote:

Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:)

Could we make it adaptable to the color scheme? I don't know if the code applies, but they managed to do it here: https://github.com/PapirusDevelopmentTeam/arc-kde/blob/master/plasma/desktoptheme/Arc-Color/icons/system.svg

They do however just leave the icon itself transparent, but perhaps that wouldn't work well with Breeze icons.

RE: D16031 I think the background circle for the avatar should either be dropped or flush with the white border.

As other have pointed out the shadows for the buttons and username look out of place. Do they use the same radius/spread as those of the clock?

Fix z-layering issue for the "-translucent" icons.

Thank you for the changes!

In the monochrome icons (size 16px and 22px) you forgot to add the stylesheet. Without it, the monochrome icons won't be able to adapt to a changing color scheme.
You will have to run the scripts "apply-stylesheet.sh" and "currentColorFillFix.sh" –from here– with your files as arguments. You will need the program "xmlstarlet" as dependency.
Or, if these scripts do not work correctly, you'll have to do it by hand. I will take icons-dark/devices/16/drive-harddisk.svg as an example.
You'd need to copy line 2-9 from the old file to the new file. You would also need to change the fill to "fill:currentColor", and then add the "class="ColorScheme-Text" ". But if you are lucky the script will work and you won't need to do a thing :)

Any update on the icon front, re: different background color? Right now my stylesheet class attribute in the icons is "ColorScheme-ViewBackground", which is a light color in the normal breeze color scheme. My thinking was that it would use the breeze dark color scheme on the login screen. Is that assumption correct or do I need to change that?

Should be fixed now!

Add missing sizes

Long outdated and irrelevant

• changed osd-sbs-right to osd-sbs-sright

• Modes OSD files out of video.svgz into osd.svgz. Removed the 64-64- prefix.

• Reverse name change

• Moved all OSD icons into video.svgz and renamed some of them.

Moved to D14971

Sure, I can do that, but I'd like to get feedback on the final form first :)

Sorry folks for the endless period of no activity. After some talking with ngraham I removed the laptop metaphor for a much more general standalone display. Also the projection screen was swapped out.

In D10937#260289, @abetts wrote:

In D10937#260277, @ngraham wrote:

Someone will need to land the changes for you. I'd prefer a few more thumbs up first. @abetts, are you good with these?

I am linking these a lot. I am "almost" there with the designs. I would just ask that the center image of the sample window be simplified. I think it has a lot of detail. Maybe we can tone it down by removing some elements and making the window look more simple.

Hello again,

I am glad you like them :)

Latest revision:

In D10937#227525, @ngraham wrote:

Those all look pretty great to me, honestly. A nice upgrade from the current icons.

For the pink column, does it look bad if you raise the projection screen so that it's only a little bit higher than the laptop on the large icons? It seems like there's room to raise it a bit and still keep the blue window aligned between them. I think it's okay if they're not aligned on the smaller versions.

An update:

In D10937#216476, @mart wrote:

one point tough: those are only going to work at a single size, as they are more vulnerable to become blurry when resized, so they would need other size versions as well (small sizes probably being like before)

as they are part of the icon theme, one can't assume where and how they will be used (want it or not, app developers will just borrow them if they like it for whatever they want to represent) so the full sizes set is needed

Some different versions. Personally, I think the first or last version is best, however, the last would probably only work in conjunction to the other icons and not as stand alones.

In D10937#216270, @ngraham wrote:

But I don't like how the window and X icons in the other icons are now much lighter and smaller. I feel like they need to be a bit bigger and/or have thicker line weights to ensure that they don't recede too much in visual importance. Maybe not as big and thick as before, but maybe a bit bigger.

I need this icon please

What am I showing when the user doesn't have a face set?

I updated the mockup(s) to include metrics. Everything has basically the same metrics as shown in image 8 to 14 except some elements are added or removed depending on which screen we are talking about. Almost everything you mentioned should be answered in the description of image 8-14. The only thing missing is the OSD, which does not change.

If there's a username box, what does the User Search button do?

That was a bug in the mockup. Well spotted! I added new mockups detailing the metrics of each part.

Showing something fancy at the top of the drawer is kind of a pattern in Kirigami, inspired by the drawer in Android. It doesn't have to just show the logo, though. If you have a better idea, shoot :)

In general I am not a fan of all the blue separator lines used. I think we should only use them as a highlight effects, to draw the attention of the user towards it. Using it too often and it become just meaningless noise. I think we can use a different, more neutral color for the same effect or often even get rid of them e.g. the Details view in picture 7 between "Kate" and the subtext.

Overall I like the mockup very much. It has some very good idea.
Some comments and suggestions below:

Looks good to me :)