palant (Wladimir Palant)
Bot

Projects

Badges

User does not have any badges.
User Since
Thu, Feb 2, 8:25 PM (3 w, 4 d)

Recent Activity

Yesterday

palant added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

If I understand correctly, if the distributor has kdesu installed under /usr/local/bin then find_program() will pick up that path and hardcode it for everybody. Even if we assume that distributors generally have kde-cli-tools installed, this will make build results depend on the state of a particular machine. Doesn't really sound desirable, I'd rather stick with an explicit override for non-standard locations.

Mon, Feb 27, 7:39 PM
palant accepted D4828: Duplicated tab should not be locked.

Fine with me, it sounds like duplicating locked state is indeed undesired with that use case.

Mon, Feb 27, 7:27 PM · Krusader
palant added a comment to D4828: Duplicated tab should not be locked.

Frankly, we explicitly tested that "locked" setting was being duplicated when this was implemented. I have no idea however what users' expectation here might be. I managed to understand what this feature does but not what it is good for. What are people using "Lock Tab" for?

Mon, Feb 27, 5:09 PM · Krusader
palant updated the diff for D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Right, I forgot to remove a piece of unused code in KrServices, done that now.

Mon, Feb 27, 5:01 PM
palant added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Forgot to reply:

Mon, Feb 27, 4:57 PM
palant updated the diff for D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Toni, thank you for pointing this out! The issue here is pretty obvious: sudoedit waits for the editor to exit, then it copies the temporary file back. Yet in case of an existing Kate session the new instance will delegate the editing to it and exit - so sudoedit thinks that the editor is already done when the file just opened up.

Mon, Feb 27, 12:52 PM
palant updated the diff for D4735: [SECURITY] Do not assume that kdesu is in PATH for user actions.

I updated this patch for changes in D4725 and improved the error message while at it. Now it should be obvious to the user where kdesu is expected to be.

Mon, Feb 27, 12:35 PM
palant updated the diff for D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.

Heh, the important part of this patch got lost in merges. Fixed it again.

Mon, Feb 27, 12:33 PM
palant updated the diff for D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.

I updated this patch for changes in D4725 and improved the error message while at it. So now it should be obvious to the user where kdesu is supposed to be.

Mon, Feb 27, 12:28 PM
palant updated the diff for D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

One more small update - rather than have a special method for kdesu in KrServices, I added a general-purpose KrServices::isExecutable() method. The actual path is available everywhere anyway.

Mon, Feb 27, 12:26 PM

Sun, Feb 26

palant updated the diff for D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Uploaded a new patch, now there is an explicit build variable called KDESU_PATH that can be overridden - I added this to the documentation. Also, there is a new KrServices::kdesuPathName() method which can be used to access that path, no more messy logic. I didn't update the error message in krslots.cpp yet - it isn't really correct already, it's much easier to fix it in D4734.

Sun, Feb 26, 3:57 PM
palant changed the visibility for D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Sun, Feb 26, 2:41 PM

Thu, Feb 23

palant added inline comments to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Thu, Feb 23, 9:00 PM
palant added inline comments to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Thu, Feb 23, 7:42 PM
palant added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

There is more information in a presentation by the same Martin Gräßlin. I was mostly interested in the details of his proof of concept but the other information turned out very useful as well. So what we are talking about is an open secret and X11 is inherently insecure (e.g. even with the changes here a key logger can still steal the password entered into kdesu). Things will hopefully get better with Wayland, eventually. But from the look of it, there is little point in keeping this review secret.

Thu, Feb 23, 1:58 PM
palant added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Strike the "ugly" part - you don't have to install the ssh-askpass package, there are alternatives. On Ubuntu I see ksshaskpass, ssh-askpass-gnome and a bunch of others. I installed ssh-askpass-gnome and now that command presents a pretty decent password prompt.

Thu, Feb 23, 11:43 AM
palant added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

Martin, thank you for the pointer to https://blog.martin-graesslin.com/blog/2017/02/editing-files-as-root/, this is very useful information (I'm not really being familiar with Linux and X11 security architecture). I created D4738 to address editing files as root. However, the more important implication here is that running Krusader as root is clearly a bad idea. At the very least, this functionality deserves a huge warning pointing out that it isn't safe. But I'd also like to make it unnecessary for the most important scenarios. As discussed on the mailing list, copying and moving files to write protected directories should offer "Execute as root" as another option beyond "Retry."

Thu, Feb 23, 11:32 AM
palant created D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.
Thu, Feb 23, 11:23 AM
palant created D4735: [SECURITY] Do not assume that kdesu is in PATH for user actions.
Thu, Feb 23, 9:57 AM
palant created D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.
Thu, Feb 23, 9:31 AM
palant updated the diff for D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

The bogus whitespace in the patch should be gone now. Looks like I should stop copying patches from the terminal, it messed up whitespace somehow.

Thu, Feb 23, 8:32 AM

Wed, Feb 22

palant created D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.
Wed, Feb 22, 7:04 PM
palant added a member for Krusader: palant.
Wed, Feb 22, 5:27 PM
palant committed R167:94a07c1830ac: Automatically configure kdesu or kdesudo, document these tools and kde-cli… (authored by palant).
Automatically configure kdesu or kdesudo, document these tools and kde-cli…
Wed, Feb 22, 8:35 AM
palant closed D4645: Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies by committing R167:94a07c1830ac: Automatically configure kdesu or kdesudo, document these tools and kde-cli….
Wed, Feb 22, 8:35 AM

Fri, Feb 17

palant added a comment to D4610: Panel: Do not select .. in a filtered view if there are other entries.

Too bad, I meant to push this one myself - I have the necessary privileges now :)

Fri, Feb 17, 6:34 PM
Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:de7858ed819e: Panel: Do not select .. in a filtered view if there are other entries (authored by palant).
Panel: Do not select .. in a filtered view if there are other entries
Fri, Feb 17, 5:36 PM
palant closed D4610: Panel: Do not select .. in a filtered view if there are other entries by committing R167:de7858ed819e: Panel: Do not select .. in a filtered view if there are other entries (authored by palant).
Fri, Feb 17, 5:36 PM
palant retitled D4645: Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies from to Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies.
Fri, Feb 17, 10:04 AM

Thu, Feb 16

palant committed R230:e45d1a01292a: Sorted list of secondary email addresses in the relicensecheck.pl script for… (authored by palant).
Sorted list of secondary email addresses in the relicensecheck.pl script for…
Thu, Feb 16, 9:57 AM
palant committed R230:255256af95a8: Allow my contributions to be relicensed (authored by palant).
Allow my contributions to be relicensed
Thu, Feb 16, 9:57 AM
palant updated the diff for D4610: Panel: Do not select .. in a filtered view if there are other entries.

Previous patch had unrelated changes, removed these now.

Thu, Feb 16, 8:13 AM
palant updated the diff for D4610: Panel: Do not select .. in a filtered view if there are other entries.

Alex, thank you, I missed that indeed. I thought that isValid() would cover that case already but apparently it doesn't. I updated the patch and everything seems to work correctly now.

Thu, Feb 16, 8:11 AM

Tue, Feb 14

palant retitled D4610: Panel: Do not select .. in a filtered view if there are other entries from to Panel: Do not select .. in a filtered view if there are other entries.
Tue, Feb 14, 4:34 PM
palant edited the content of Krusader.
Tue, Feb 14, 9:01 AM · Krusader
palant edited the content of Krusader.
Tue, Feb 14, 8:42 AM · Krusader

Mon, Feb 13

Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:4a82a55deee2: #375994 - List kio-extras under dependencies as recommended package (authored by palant).
#375994 - List kio-extras under dependencies as recommended package
Mon, Feb 13, 8:50 PM
Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:3bdf6fe0f39f: #375894 - Use case-insensitive as default for text search (authored by palant).
#375894 - Use case-insensitive as default for text search
Mon, Feb 13, 8:50 PM
Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:b56a40421e24: #314258 - Duplicate tab settings when duplicating tabs (authored by palant).
#314258 - Duplicate tab settings when duplicating tabs
Mon, Feb 13, 8:50 PM
Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:972a8501d834: #375830 - Don't send SIGINT to terminal emulator unnecessarily (authored by palant).
#375830 - Don't send SIGINT to terminal emulator unnecessarily
Mon, Feb 13, 8:50 PM
Alexander Bikadorov <alex.bikadorov@kdemail.net> committed R167:1db4a2b8a3e6: #375831 - Sort empty file extensions correctly (authored by palant).
#375831 - Sort empty file extensions correctly
Mon, Feb 13, 8:50 PM
palant edited the content of Krusader.
Mon, Feb 13, 7:12 PM · Krusader

Fri, Feb 10

palant updated the diff for D4418: #314258 - Duplicate tab settings when duplicating tabs.

I reverted to the original approach and applied suggested changes. As far as locked tabs are concerned, everything seems to work correctly for me. Could it be that the issue there was being caused by the extra ListPanel::start() call?

Fri, Feb 10, 3:17 PM · Krusader

Wed, Feb 8

palant added a comment to T5062: Improve search results tab.

Sure, that would be easy - but there is little point as long as Lister isn't the default.

Wed, Feb 8, 4:04 PM · Krusader
palant added a comment to T5062: Improve search results tab.

Well, I'm stuck. The way I see it, the searchText method of KTextEditor::Document merely gives you the search results but doesn't affect the UI. There doesn't seem to be a way to manipulate the search bar, in particular the method KateSearchBar::setSearchPattern() is only called by unit tests.

Wed, Feb 8, 9:51 AM · Krusader

Tue, Feb 7

palant added a comment to T5062: Improve search results tab.

KParts::TextExtension would have been too easy. At least on my system both viewer and editor are using KTextEditor which currently doesn't appear to implement KParts::TextExtension. It implements its own KTextEditor::Document interface instead which also allows searching but requires introducing a new dependency (not to mention fallback code). I am trying to make it work.

Tue, Feb 7, 2:27 PM · Krusader

Mon, Feb 6

palant updated the diff for D4418: #314258 - Duplicate tab settings when duplicating tabs.

I now implemented "proper" settings duplication as suggested. Frankly, I'm not convinced that this approach is better. It introduces quite a bit of code which is almost the same as what was there before but not quite. Also, is there really any setting where it makes sense to restore it on startup but not to duplicate when you duplicate the tab? The only one I left out here is the tab history but even that one should arguably better be duplicated.

Mon, Feb 6, 8:47 AM · Krusader

Sat, Feb 4

palant added a reviewer for D4433: #375994 - List kio-extras under dependencies as recommended package: Krusader.
Sat, Feb 4, 9:20 PM · Krusader
palant added a comment to D4420: #375894 - Use case-insensitive as default for text search.

Well, grep is a command line utility - usability isn't a huge concern with those. As far as GUI tools go, I don't know any where case-sensitive search would be the default, and I wouldn't expect it either. So IMHO remembering these settings across restarts (or rather the selected search profile) would be nice to have but not a replacement for sane defaults.

Sat, Feb 4, 9:00 PM · Krusader
palant added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Yes, I used a temporary config group because the code in PanelManager::slotRecreatePanels() does it like that - this might not be the cleanest approach however. I will add a ListPanel::duplicateSettings(ListPanel*) method instead that restores a different set than ListPanel::restoreSettings(KConfigGroup). The danger here is however that these two methods get out of sync as new settings are added - some new settings will be restored by the latter but not the former even where both would make sense.

Sat, Feb 4, 7:52 PM · Krusader

Fri, Feb 3

palant added a comment to T5062: Improve search results tab.

This mockup is great but implementation will certainly take time. Unless somebody plans to work on this really soon, maybe a simpler solution is worth considering: when opening the viewer from the file search with non-empty text, do a search for this text in the viewer automatically. So the first result line should be selected immediately and pressing F3 should bring up the other matches. That's what Total Commander does.

Fri, Feb 3, 12:35 PM · Krusader
palant added a comment to D3994: add asynchronous vfs refresh.
In D3994#77448, @abika wrote:

I'm actually unsure if there is any benefit for a "real" async refresh. The panel currently depends on it and the Qt event loop prevents an UI freeze during a long refresh.

Fri, Feb 3, 12:14 PM · Krusader
palant retitled D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily from #375830 - Don't send SIGINT to terminal emulator unnecessary to #375830 - Don't send SIGINT to terminal emulator unnecessarily.
Fri, Feb 3, 12:06 PM · Krusader
palant updated subscribers of D4417: #375831 - Sort empty file extensions correctly.
Fri, Feb 3, 12:03 PM · Krusader
palant updated subscribers of D4418: #314258 - Duplicate tab settings when duplicating tabs.
Fri, Feb 3, 12:02 PM · Krusader
palant updated subscribers of D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.
Fri, Feb 3, 12:02 PM · Krusader
palant updated subscribers of D4420: #375894 - Use case-insensitive as default for text search.
Fri, Feb 3, 12:02 PM · Krusader
palant retitled D4427: Update "get involved" page to indicate how one can register from to Update "get involved" page to indicate how one can register.
Fri, Feb 3, 11:58 AM · Websites, Krusader

Thu, Feb 2

palant retitled D4420: #375894 - Use case-insensitive as default for text search from to #375894 - Use case-insensitive as default for text search.
Thu, Feb 2, 9:16 PM · Krusader
palant retitled D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily from to #375830 - Don't send SIGINT to terminal emulator unnecessary.
Thu, Feb 2, 9:11 PM · Krusader
palant retitled D4418: #314258 - Duplicate tab settings when duplicating tabs from to #314258 - Duplicate tab settings when duplicating tabs.
Thu, Feb 2, 8:58 PM · Krusader
palant retitled D4417: #375831 - Sort empty file extensions correctly from to #375831 - Sort empty file extensions correctly.
Thu, Feb 2, 8:35 PM · Krusader