I commonly find myself in this situation when browsing a directory tree: I filter the view to locate a directory, press Right, then filter again to locate another directory and press Right again. Oops - that directory was the only entry, yet Krusader left .. selected so that I'm now back in the parent directory. While one part of the issue here is the visuals on a high-DPI screen, leaving .. selected when filtering just isn't good for the user experience. In particular, Total Commander seems to select the first entry matching the filter.
Details
Details
- Reviewers
martinkostolny - Group Reviewers
Krusader - Commits
- R167:de7858ed819e: Panel: Do not select .. in a filtered view if there are other entries
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I don't want to be pedantic but there is a small misbehavior: when the current item is ".." and "Show hidden files" setting is changed (Alt+".") the current jumps to the first file now. Probably nobody will ever notice but checking against empty _quickFilterMask should also solve it.
Comment Actions
Alex, thank you, I missed that indeed. I thought that isValid() would cover that case already but apparently it doesn't. I updated the patch and everything seems to work correctly now.
Comment Actions
Added a small fix: _count > 0 instead of _count > 1; the dummy file itself is not counted.
[Author and auto-closing was working now with arc]