Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies
ClosedPublic

Authored by palant on Feb 17 2017, 10:04 AM.

Details

Summary

"Start Root Mode Krusader" feature didn't work for me out of the box, turned out that it relies on kdesu tool. This tool doesn't appear to be available for modern Ubuntu distributions but kdesudo will work just fine. So this change will make sure that both kdesu and kdesudo are detected and configured if present. It also documents them as optional dependencies.

While at it, I've also added kde-cli-tools as an optional dependency. This is actually a transitive dependency - it contains the mime type editor required by the File Properties dialog provided by KF5::WidgetsAddons.

The other changes in the INSTALL dialog are merely trailing whitespace being removed (my editor does that automatically).

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
palant updated this revision to Diff 11442.Feb 17 2017, 10:04 AM
palant retitled this revision from to Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies.
palant updated this object.
palant edited the test plan for this revision. (Show Details)
palant added a reviewer: Krusader.
palant set the repository for this revision to R167 Krusader.
abika accepted this revision.Feb 17 2017, 5:48 PM
abika added a reviewer: abika.
abika added a subscriber: abika.

Thanks, works fine. Question is why Ubuntu is having a different tool doing the same thing.

(The existing code is kind of ugly (again) but that's not your fault.)

This revision is now accepted and ready to land.Feb 17 2017, 5:48 PM
martinkostolny accepted this revision.Feb 21 2017, 8:59 PM
martinkostolny added a subscriber: martinkostolny.

Thanks! I didn't test it in Kubuntu but it still works fine on Arch.

This revision was automatically updated to reflect the committed changes.