#375894 - Use case-insensitive as default for text search
ClosedPublic

Authored by palant on Feb 2 2017, 9:16 PM.

Details

Reviewers
asensi
martinkostolny
abika
Group Reviewers
Krusader
Summary

This reverses the default for case sensitivity when searching for files with particular text.

Test Plan

See STR in bug.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
palant updated this revision to Diff 10876.Feb 2 2017, 9:16 PM
palant retitled this revision from to #375894 - Use case-insensitive as default for text search.
palant updated this object.
palant edited the test plan for this revision. (Show Details)
palant added a reviewer: Krusader.
palant set the repository for this revision to R167 Krusader.
palant added a project: Krusader.
abika added a subscriber: abika.Feb 4 2017, 2:10 PM

I personally don't care. Default search with grep is case sensitive. Any other opinions?

The arguments about default case insensitivity in editors are convincing. But I'm heavy user of this search dialog and like the default case-sensitive setting which is on par with grep (like Alex just said). Maybe the best solution would be to make the setting persistent over Krusader restarts?

palant added a comment.EditedFeb 4 2017, 9:00 PM

Well, grep is a command line utility - usability isn't a huge concern with those. I think that grep's default behavior wasn't motivated by expectations of human beings (people rarely expect case-sensitive search) but rather performance concerns (back when grep was conceived the performance overhead of lowercasing strings was considerable). As far as GUI tools go, I don't know any where case-sensitive search would be the default, and I wouldn't expect it either. In fact, I filed this bug after wondering why my search didn't turn up any results. So IMHO remembering these settings across restarts (or rather the selected search profile) would be nice to have but not a replacement for sane defaults.

martinkostolny accepted this revision.Feb 8 2017, 12:00 AM
martinkostolny added a reviewer: martinkostolny.

I find these arguments good enough to set the default to case insensitive, like You proposed :).

This revision is now accepted and ready to land.Feb 8 2017, 12:00 AM
asensi added a subscriber: asensi.EditedFeb 8 2017, 8:51 AM

As far as GUI tools go, I don't know any where case-sensitive search would be the default, and I wouldn't expect it either.

I've looked and: Kate, Konsole, Dolphin, Okular, etc. have case-insensitive search by default...

asensi accepted this revision.Feb 8 2017, 8:58 AM
asensi added a reviewer: asensi.
abika accepted this revision.Feb 8 2017, 3:02 PM
abika added a reviewer: abika.

Like I said, I don't really care. In KFind case sensitivity is also off by default.

However, the better solution would be to save the option setting in the Search KConfigGroup so that this only matters the first time the search is used.

abika closed this revision.Feb 13 2017, 8:54 PM

Merged with master