Differential D17789

Add handling for the identity packet to be split across two messages.
ClosedPublic
Actions

Authored by sarcot on Dec 25 2018, 2:09 AM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R224:97551d09ffbb: Add handling for the identity packet to be split across two messages.
Summary

If the identity packet is split across two packets, then save it until we get a notification that more data is available for reading over the bluetooth link.

Test Plan

Connect a phone and laptop over Bluetooth, and verify that both the phone and laptop are able to see each other, and that either side can start and successfully go through the pairing process.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sarcot created this revision.Dec 25 2018, 2:09 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 25 2018, 2:09 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sarcot requested review of this revision.Dec 25 2018, 2:09 AM
mtijink accepted this revision.Dec 28 2018, 5:10 PM
mtijink added a subscriber: mtijink.

Works for me, thanks!

This revision is now accepted and ready to land.Dec 28 2018, 5:10 PM
sarcot added a comment.Dec 30 2018, 3:17 AM

I don't have permission to make commits. Could someone commit this changeset for me?

Closed by commit R224:97551d09ffbb: Add handling for the identity packet to be split across two messages. (authored by mtijink). · Explain WhyDec 31 2018, 12:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48442

View Options

core/backends/bluetooth/bluetoothlinkprovider.cpp

Loading...
View Options

core/backends/bluetooth/bluetoothpairinghandler.cpp

Loading...