Add description of bluetooth multiplexing protocol
ClosedPublic

Authored by mtijink on Sat, Jan 5, 12:24 PM.

Details

Summary

As mentioned on telegram, there are some fundamental issues with bluetooth. The only approach I could get working was multiplexing: manually sending multiple streams of data over a single connection.

This is the description of that multiplexing protocol. I have an implementation of this protocol, but I'd first like some feedback to see if this is what we're going to use before finishing up those patches.

See the document itself for more details. I make the protocol forward-compatible, although I don't expect we will need ever that.

Test Plan

None, this is just a description.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink created this revision.Sat, Jan 5, 12:24 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSat, Jan 5, 12:24 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
mtijink requested review of this revision.Sat, Jan 5, 12:24 PM
mtijink updated this revision to Diff 49174.Thu, Jan 10, 4:43 PM

Update to require sending of protocol version message, this makes future extensions easier to handle.

Any thought on this approach? If not, I'll start sending bluetooth patches.

albertvaka accepted this revision.Wed, Jan 16, 11:47 AM
albertvaka added a subscriber: albertvaka.

Looks good to me. Something like this could even end up being used for TCP instead of using lots of sockets. Also, the MESSAGE_READ is a good idea: with our current TCP approach, sometimes we create sockets that no one is going to read from and they are leaked.

This revision is now accepted and ready to land.Wed, Jan 16, 11:47 AM
This revision was automatically updated to reflect the committed changes.