Differential D12618

Add assertions and checks to album art fetch code
ClosedPublic
Actions

Authored by mtijink on Apr 30 2018, 6:07 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:d6c3803ea259: Add assertions and checks to album art fetch code
Summary

Add a couple of assertions and checks to the album art fetch code. Hopefully fixes bug https://bugs.kde.org/show_bug.cgi?id=393274, or otherwise at least gives a bit more information.

BUG 393274

Test Plan

Fixes the bug, according to the reporter.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink created this revision.Apr 30 2018, 6:07 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 30 2018, 6:07 PM
mtijink requested review of this revision.Apr 30 2018, 6:07 PM
mtijink added a comment.Apr 30 2018, 6:08 PM

APK:

kdeconnect-26417c8.apk4 MBDownload

mtijink edited the summary of this revision. (Show Details)May 1 2018, 5:01 PM
mtijink edited the test plan for this revision. (Show Details)
albertvaka accepted this revision.May 1 2018, 5:15 PM
albertvaka added a subscriber: albertvaka.
albertvaka added inline comments.
src/org/kde/kdeconnect/Plugins/MprisPlugin/AlbumArtCache.java
273

Maybe move inside the for loop? currentUrl keeps changing

This revision is now accepted and ready to land.May 1 2018, 5:15 PM
mtijink marked an inline comment as done.May 1 2018, 5:26 PM
mtijink added inline comments.
src/org/kde/kdeconnect/Plugins/MprisPlugin/AlbumArtCache.java
273

There already was such a check in the loop.

Closed by commit R225:d6c3803ea259: Add assertions and checks to album art fetch code (authored by mtijink). · Explain WhyMay 1 2018, 5:27 PM
This revision was automatically updated to reflect the committed changes.
mtijink marked an inline comment as done.

Revision Contents
Changeset List

Diff 33412

View Options

src/org/kde/kdeconnect/Plugins/MprisPlugin/AlbumArtCache.java

Loading...