Differential D12812

Enable desktop2desktop keyboard input
ClosedPublic
Actions

Authored by nicolasfella on May 10 2018, 7:43 PM.

Details

Reviewers

apol

Maniphest Tasks

T6701: Support desktop to desktop text input

Commits

R224:3c4aa590f10c: Enable desktop2desktop keyboard input

Summary

Fixes T6701

The reason it did not work before is that the "Keyboard" did not report itself as available.

Test Plan

Type in plasmoid on one Desktop, see text on another.
Note that no ack packets are sent, so the text does not appear in the original input text field. I want to await the discussion in D12670 before doing that

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.May 10 2018, 7:43 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptMay 10 2018, 7:43 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.May 10 2018, 7:43 PM

Looks sensible, but I can't test this. Consider it accepted if nobody else reviews in the coming days.

apol accepted this revision.May 11 2018, 11:29 PM

This revision is now accepted and ready to land.May 11 2018, 11:29 PM

Closed by commit R224:3c4aa590f10c: Enable desktop2desktop keyboard input (authored by nicolasfella). · Explain WhyMay 12 2018, 3:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/mousepad/abstractremoteinput.h (1 line)
M			plugins/mousepad/kdeconnect_mousepad.json (4 lines)
M			plugins/mousepad/mousepadplugin.h (4 lines)
M			plugins/mousepad/mousepadplugin.cpp (7 lines)
M			plugins/mousepad/x11remoteinput.h (1 line)
M			plugins/mousepad/x11remoteinput.cpp (5 lines)