Differential D12212

Hide Available devices section if no devices are available
ClosedPublic
Actions

Authored by nicolasfella on Apr 14 2018, 8:39 PM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R225:9837c89f350e: Hide Available devices section if no devices are available
Summary

Before:

After:

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 14 2018, 8:39 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 14 2018, 8:39 PM
nicolasfella requested review of this revision.Apr 14 2018, 8:39 PM
nicolasfella edited the summary of this revision. (Show Details)Apr 14 2018, 8:42 PM
mtijink added a subscriber: mtijink.Apr 15 2018, 12:12 PM

An empty "available devices" section does make it clear that none of the devices are available at the moment (which might be unclear with only "remembered devices"). I'd suggest only hiding it there's at least one connected device.

nicolasfella updated this revision to Diff 32411.Apr 17 2018, 5:23 PM
  • Only hide section when there is at least one device connected
mtijink accepted this revision.Apr 17 2018, 6:42 PM

Looks good to me!

This revision is now accepted and ready to land.Apr 17 2018, 6:42 PM
Closed by commit R225:9837c89f350e: Hide Available devices section if no devices are available (authored by nicolasfella). · Explain WhyApr 17 2018, 6:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32419

View Options

src/org/kde/kdeconnect/UserInterface/List/SectionItem.java

Loading...
View Options

src/org/kde/kdeconnect/UserInterface/PairingFragment.java

Loading...