Differential D12232

Simplify failed plugin list creation
ClosedPublic
Actions

Authored by nicolasfella on Apr 15 2018, 8:25 PM.

Details

Reviewers
None
Group Reviewers
KDE Connect
Commits
R225:a4e2af2c51a6: Simplify failed plugin list creation
Summary

Use some lambdas to simplify the code

Test Plan

Denie some permissions, open permission explanation dialogs

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Apr 15 2018, 8:25 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 15 2018, 8:25 PM
nicolasfella requested review of this revision.Apr 15 2018, 8:25 PM
nicolasfella updated this revision to Diff 32223.Apr 15 2018, 8:28 PM
  • Add license header
mtijink added a subscriber: mtijink.Apr 16 2018, 3:11 PM
mtijink added inline comments.
src/org/kde/kdeconnect/UserInterface/DeviceFragment.java
329

You removed the retry code. Does that make sense? (ie never fired, or retries happen anyway?)

src/org/kde/kdeconnect/UserInterface/PluginSmallEntryItem.java
25 ↗(On Diff #32223)

What does this name mean? I'd pick something clearer, although that seems hard in this case.

nicolasfella updated this revision to Diff 32397.Apr 17 2018, 4:09 PM
  • Revert lambda, nename PluginSmallEntryItem
nicolasfella added inline comments.Apr 17 2018, 4:11 PM
src/org/kde/kdeconnect/UserInterface/DeviceFragment.java
329

It was blocking making it a lambda, but it was probably a bad idea to blindly remove it

mtijink added inline comments.Apr 17 2018, 4:45 PM
src/org/kde/kdeconnect/UserInterface/PluginListItem.java
25 ↗(On Diff #32397)

Better, but these are only for the required permissions, failure, etc., right? Maybe FailedPluginListItem?

Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptSep 12 2018, 11:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2018, 5:03 PM
Closed by commit R225:a4e2af2c51a6: Simplify failed plugin list creation (authored by nicolasfella). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42870

View Options

src/org/kde/kdeconnect/UserInterface/DeviceFragment.java

Loading...
View Options

src/org/kde/kdeconnect/UserInterface/FailedPluginListItem.java

Loading...