Use placeholder instead of label
Changes PlannedPublic

Authored by ognarb on Mar 14 2019, 8:12 PM.

Details

Summary

See https://hig.kde.org/style/writing/placeholder.html

Also change Find -> Search in Search and replace module

Screenshot:


Test Plan

Compile and run

Diff Detail

Repository
R39 KTextEditor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9602
Build 9620: arc lint + arc unit
ognarb created this revision.Mar 14 2019, 8:12 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 14 2019, 8:12 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
ognarb requested review of this revision.Mar 14 2019, 8:12 PM
ognarb edited the summary of this revision. (Show Details)Mar 14 2019, 8:51 PM
ognarb added a reviewer: KTextEditor.
ognarb added a reviewer: VDG.
ognarb updated this revision to Diff 53922.Mar 14 2019, 8:52 PM

Use proper Unicode ellipsis

ognarb planned changes to this revision.Mar 14 2019, 9:56 PM

Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms.

So the change in Search and replace need to be reverted.

So the change in Search and replace need to be reverted.

That should @ngraham decide. See also https://phabricator.kde.org/T10258#178907

I would badly suggest to use in both cases the same term, "Find" or "Search".

Should it be keep as shown above, I suggest to remove the unneeded space left from the input fields in power mode, so that it fit to the left edge and looks like the normal mode GUI.

"Find" and "search" are different things. Broadly:

  • "Find" is limited to items in the current view only, and usually pertains to text.
  • "Search" is anything broader than that.

So for this, "Find" is the appropriate term.

cfeck added a subscriber: cfeck.Mar 15 2019, 5:25 PM
  • "Find" is limited to items in the current view only, and usually pertains to text.

I prefer the term "Filter" for this. If there is no filter, you see everything, if there is a filter, you only see the items that match. No additional search is performed.

That's different. "Filter" actually hides non-matched entries. "Find" highlights them while keeping the context and surrounding content.

For me is your distinction between Find/Search not very intuitive. But OK, in terms of HIG may that somehow a wanted subtlety. Filter on the other hand is something else, yes, and here not fitting. So "Find..." in both cases.

Not answered are the questions about the removed label and if triple dots are bad, OK or in any case to substitute by true a ellipsis. Well, the latter I asked elsewhere T10258#178907.

All these Q/A should be added as examples to the HIG https://hig.kde.org/style/writing/placeholder.html

For me is your distinction between Find/Search not very intuitive. But OK, in terms of HIG may that somehow a wanted subtlety. Filter on the other hand is something else, yes, and here not fitting. So "Find..." in both cases.

Not answered are the questions about the removed label

The idea is that we don't need a label if there's appropriate placeholder text.

and if triple dots are bad, OK or in any case to substitute by true a ellipsis. Well, the latter I asked elsewhere T10258#178907.

I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think.

All these Q/A should be added as examples to the HIG https://hig.kde.org/style/writing/placeholder.html

Good idea. https://hig.kde.org/resources/contribute.html

:)

I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think.

The advantage of using the unicode ellipsis character, is that this character carries a semantic meaning instead of just being a multiple of dots and uses a proper amount of space between the dot, also the hig use the unicode character. The only disadvantage is then used in monospace font.

Can you bring this up in the VDG channel? If we're going to use the correct character, we should do it everywhere.

Not answered are the questions about the removed label

The idea is that we don't need a label if there's appropriate placeholder text.

Yes. But the mentioned HIG is slightly confusing and @ognarb will that revert again (bring back the label) here because of that. (at least I have read so)

All these Q/A should be added as examples to the HIG https://hig.kde.org/style/writing/placeholder.html

Good idea. https://hig.kde.org/resources/contribute.html

I think every mandatory standard should someone write who has the needed authority and responsibility and not some noob like me.

Regarding ellipsis, I'm not a fan of that special char, but that doesn't matter.

Hi, if we do that: Could we then remove the "Mode:", too and move that into the combobox?
Perhaps like "Plain text search", "Whole words search", ...
Otherwise the search&replace doesn't save space and it looks "strange".