This patch checks if the entered closing bracket is already balanced and
skip the input in this case. Targets the "nested autbracket" problem
without to base on this enabled config setting.
BUG: 368580
FIXED-IN: 5.56
This patch checks if the entered closing bracket is already balanced and
skip the input in this case. Targets the "nested autbracket" problem
without to base on this enabled config setting.
BUG: 368580
FIXED-IN: 5.56
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Works for me, beside that the patch no longer cleanly applies.
But with some false removed and the later parts skipped, it did work as advertised.
I think this change introduces a regression: This code does not check for "view->config()->autoBrackets()", so it's *ALWAYS* active, which I do not want. Consider this:
if (bla |) { ... }
Now you type && foo(), the result is then:
if (bla && foo() { ... }
Notice the unbalanced closing ), which is due to this patch.
Can we either revert this, or at least add config check?