Ensure highlighted folding marker after unfold
Needs ReviewPublic

Authored by loh.tar on Thu, Apr 25, 2:22 PM.

Details

Reviewers
None
Group Reviewers
KTextEditor
Summary

With this patch behaves the unfold like the fold to highlight the start and end marker

  • Remove unneeded delete
Test Plan

autotest looks good :-S

Compare what happens when unfold like this

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Thu, Apr 25, 2:22 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptThu, Apr 25, 2:22 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Thu, Apr 25, 2:22 PM

I think about a patch to issue the foldingPreview in case of unfold when done by click on the icon bar. Unfortunately would that need some bigger changes at the toggleFolding functions to return what was done.

Oops! Noticed that we have now some odd behavior when issued the toggle child action, will take a look.

loh.tar updated this revision to Diff 56977.Thu, Apr 25, 3:10 PM
  • Ensure cursor don't move when isssue toggleFoldingsInRange
loh.tar updated this revision to Diff 57002.Fri, Apr 26, 5:15 AM
loh.tar edited the test plan for this revision. (Show Details)
  • Fix jump of big unfold II :-/

I notice that this not yet works when done by Short-Cut/Menu and there are nested folding ranges