[RFC] KateRenderer: Show tabs and space characters the smart way
Needs ReviewPublic

Authored by loh.tar on Feb 23 2019, 3:11 PM.

Details

Reviewers
None
Group Reviewers
KTextEditor
Summary

The original bug says: Show tabs and space characters only on selection
but I thought this way is it more handy

  • Show them always in current line
  • Show them as requested in selected lines
  • Enhanced to show also non printable spaces

Questions:

  • Could it be the default, without the need for an option?
  • Ideas for naming?

BUG: 333446

Test Plan

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Feb 23 2019, 3:11 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 23 2019, 3:11 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Feb 23 2019, 3:11 PM

I think this, since it removes visual clutter. I think this should be configurable...

Question is how to properly add an option in the config widget, since in the code I can see that this feature changes several options: tabs + trailing spaces + nonprintable chars.
One way would be to turn the checkable options into tri-state comboboxes: Show trailing spaces [Always, In Current Line and Selection, Never]

Pushing this further, it would maybe be interesting to "Show indentation lines" only for the current block.

PS: Better naming for foobar ? :-)

loh.tar updated this revision to Diff 56110.Apr 13 2019, 7:07 AM
  • Rebase on master to keep it compile
  • Not further investigated if changes by D19163 needs more tweeks here

PS: Better naming for foobar ? :-)

Yes :-)

I think this should be configurable...

ATM me too
Without more feedback, like "what a great feature" it has very low prio for me

meven edited the summary of this revision. (Show Details)Apr 13 2019, 8:29 AM