Make warning and error messages grammatically correct
ClosedPublic
Actions

Authored by ngraham on Apr 13 2020, 4:21 PM.

Details

Reviewers

ivan

Group Reviewers

VDG

Commits

Summary

These messages are currently comma splices, which are incorrect.

Repository

R845 Plasma Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ngraham requested review of this revision.Apr 13 2020, 4:21 PM

Maybe "Unable to close the vault; it is being used by %1" -> "Unable to close the vault as it is being used by %1" ?

"Unable to close the vault; an application is using it" -> "Unable to close the vault because an application is using it"

While writing for Manning, I was told to avoid semicolons and try to rephrase the sentence instead.

; -> as

"because" is better

This revision is now accepted and ready to land.Apr 13 2020, 6:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kded/engine/vault.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80028	b480831		Apr 13 2020, 4:21 PM	★	★
Diff 2	80030	b480831	; -> as	Apr 13 2020, 4:54 PM	★	★
Diff 3	80031	b480831	"because" is better	Apr 13 2020, 4:55 PM	★	★
Diff 4	80043	b480831	R845:d17f0e717fcfd9aeaf5f669f168845ba39701292	Apr 13 2020, 6:34 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3854e942b550	00b71b59c13c	b480831d5cf5	Nate Graham	Make warning and error messages grammatically correct (Show More…)	Apr 13 2020, 4:21 PM