Show previews on encrypted filesystems
ClosedPublic

Authored by marcingu on Apr 11 2020, 12:22 PM.

Details

Summary

Instead of skipping generating previews on encrypted filesystems, do create them but don't cache.

BUG: 411919
FIXED-IN: 5.70

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marcingu created this revision.Apr 11 2020, 12:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 11 2020, 12:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
marcingu requested review of this revision.Apr 11 2020, 12:22 PM
ngraham added a subscriber: ngraham.

General idea looks sane to me. Thanks for working on this; it's been one of those minor annoyances of mine.

src/widgets/previewjob.cpp
718

unrelated change

ngraham accepted this revision.Apr 13 2020, 4:01 AM

Works and looks good to me modulo one comment, but let's wait for the other reviewers too.

This revision is now accepted and ready to land.Apr 13 2020, 4:01 AM
ivan added inline comments.Apr 13 2020, 7:21 AM
src/widgets/previewjob.cpp
692

const

marcingu updated this revision to Diff 79985.Apr 13 2020, 8:17 AM

Review fixes

marcingu marked 2 inline comments as done.Apr 13 2020, 8:17 AM
ivan added inline comments.Apr 13 2020, 9:39 AM
src/widgets/previewjob.cpp
697

Since you are already changing this, move these two checks to the line after bSave - short-circuit logic to skip calling ->property and the rest if these two are not satisfied.

dfaure added inline comments.Apr 13 2020, 9:49 AM
src/widgets/previewjob.cpp
307

"for which will be used" ... remove for ?

marcingu updated this revision to Diff 79991.Apr 13 2020, 10:24 AM

Moving boolean variables to the front of logic statement.

marcingu marked 2 inline comments as done.Apr 13 2020, 10:24 AM
ngraham added inline comments.Apr 13 2020, 1:44 PM
src/widgets/previewjob.cpp
718

Now there are extra spaces on that line. :)

marcingu updated this revision to Diff 80022.Apr 13 2020, 3:51 PM

Removing extra whitespaces

marcingu marked an inline comment as done.Apr 13 2020, 3:52 PM
ivan accepted this revision.Apr 13 2020, 3:54 PM
ngraham edited the summary of this revision. (Show Details)Apr 13 2020, 4:03 PM

Excellent job. This is a real improvement. Keep the great patches coming! :)

This revision was automatically updated to reflect the committed changes.