[applet] Port to Kirigami.PlaceholderMessage
ClosedPublic

Authored by ngraham on Apr 22 2020, 8:10 PM.

Details

Summary

This patch ports the Vaults applet to use the new Kirigami.PlaceholderMessage that was
just created to standardize the appearance of placeholder messages.

This requires adding Kirigami as a dependency.

Test Plan

No change when there is at least one vault set up

Diff Detail

Repository
R845 Plasma Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 22 2020, 8:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 22 2020, 8:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 22 2020, 8:10 PM
ngraham edited the summary of this revision. (Show Details)Apr 22 2020, 8:11 PM
ngraham retitled this revision from [applet] port to Kirigami.PlaceholderMessage to [applet] Port to Kirigami.PlaceholderMessage.Apr 22 2020, 9:09 PM
ivan added a comment.Apr 23 2020, 8:50 PM

Not sure I like pulling in Kirigami just for this. Are there other places where Kirigami could improve the Vaults applet?

I know what you mean, but Kirigami is already a dependency of Plasma itself, which a user of Plasma Vaults presumably already has installed. :)

When I created the ExpandableListItem, I put it in plasma-framework, but I almost put it in Kirigami, and for Plasma 6, there's talk of deprecating PlasmaComponents and porting everything to use Kirigami components.

ivan accepted this revision.Apr 24 2020, 4:43 AM

Fair enough.

This revision is now accepted and ready to land.Apr 24 2020, 4:43 AM
This revision was automatically updated to reflect the committed changes.