- User Since
- Jan 26 2017, 12:00 PM (103 w, 2 d)
Thu, Jan 10
Fixed two links to docs.kde.org
Sep 21 2018
Sep 17 2018
Sep 18 2017
- Added test cases for new code blocks in Markdown
Sep 17 2017
Aug 19 2017
Aug 17 2017
Removed leading and trailing spaces inside XML tags (in less.xml), to make it possible to build the framework.
Jun 24 2017
Added a test file (autotests/input/highlight.less).
May 10 2017
Feb 18 2017
Updated to work with new cmake/FindEditorConfig.cmake.
Feb 15 2017
key and value are const.
Pulled check-variable-functions out of EditorConfig class, moved some variable definitions into main loop of parser.
Feb 14 2017
Simplified the constructor and reduced parser indentation.
Yes, it was good when actual parsing was delegated to a separate function, but we’ve decided to merge all parsing-related functions.
FindLibGit2.cmake and other files include such fragment:
Feb 13 2017
Added version checking support.
It seems there isn’t any version string in library headers (editorconfig.h, editorconfig_handle.h), is there any other cross-distribution way to obtain library version?
Fixed src/CMakeLists.txt to make EditorConfig support truly optional, removed interpret and interpretLine functions (so parsing is back in parse), simplified EditorConfig class constructor, fixed memory leak in DocumentPrivate.
Feb 12 2017
Moved EditorConfig-related logic into a separate class and made it optional (no longer a KTextEditor dependency).
In the new EditorConfig class I need to use DocumentPrivate’s checkBoolValue and checkIntValue methods, but they’re declared private. I think it should be OK to make them public as they’re static anyway, but I’d like to hear what’s your opinion. Setting EditorConfig as DocumentPrivate’s friend didn’t help.
Thanks for your comments. I’ve managed to make editorconfig optional using the mentioned FindEditorConfig.cmake module (I had to change its name to Findeditorconfig.cmake). Should I create a new diff in ECM repository to add this file?
Now I’m going to create a separate class for EditorConfig parsing.