gszymaszek (Grzegorz Szymaszek)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 26 2017, 12:00 PM (150 w, 1 d)
Availability
Available

Recent Activity

Sep 30 2019

gszymaszek committed R216:25b08fe3f4c6: Highlight GeoJSON files as if they were plain JSON (authored by gszymaszek).
Highlight GeoJSON files as if they were plain JSON
Sep 30 2019, 11:42 AM
gszymaszek closed D24306: Highlight GeoJSON files as if they were plain JSON.
Sep 30 2019, 11:42 AM · Frameworks, Kate
gszymaszek requested review of D24306: Highlight GeoJSON files as if they were plain JSON.
Sep 30 2019, 11:30 AM · Frameworks, Kate

Jan 10 2019

gszymaszek committed R39:b64681408d84: Use HTTPS, if available, in links visible to users (authored by gszymaszek).
Use HTTPS, if available, in links visible to users
Jan 10 2019, 9:57 AM
gszymaszek closed D18148: Use HTTPS, if available, in links visible to users.
Jan 10 2019, 9:57 AM · Frameworks, Kate
gszymaszek updated the diff for D18148: Use HTTPS, if available, in links visible to users.

Fixed two links to docs.kde.org

Jan 10 2019, 8:44 AM · Frameworks, Kate
gszymaszek added a reviewer for D18148: Use HTTPS, if available, in links visible to users: KTextEditor.
Jan 10 2019, 7:45 AM · Frameworks, Kate
gszymaszek requested review of D18148: Use HTTPS, if available, in links visible to users.
Jan 10 2019, 7:43 AM · Frameworks, Kate

Sep 21 2018

gszymaszek requested changes to D15639: Add editorconfig.
Sep 21 2018, 7:05 PM · KDE Edu

Sep 17 2018

gszymaszek accepted D15383: Add editorconfig.
Sep 17 2018, 7:34 PM · Konsole
gszymaszek requested changes to D15383: Add editorconfig.
Sep 17 2018, 12:16 PM · Konsole

Sep 18 2017

gszymaszek updated the diff for D7864: Basic support for PHP and Python fenced code blocks in Markdown.
  • Removed JavaScript code blocks in Markdown support since it didn’t work
  • Added test cases for new code blocks in Markdown
Sep 18 2017, 9:10 AM · Frameworks

Sep 17 2017

gszymaszek updated subscribers of D7864: Basic support for PHP and Python fenced code blocks in Markdown.

Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974).

Sep 17 2017, 7:29 PM · Frameworks
gszymaszek created D7864: Basic support for PHP and Python fenced code blocks in Markdown.
Sep 17 2017, 7:24 PM · Frameworks

Aug 19 2017

gszymaszek committed R216:ca846fbda318: Rebased Less syntax highlighting on SCSS one (authored by gszymaszek).
Rebased Less syntax highlighting on SCSS one
Aug 19 2017, 2:07 PM
gszymaszek closed D5799: Rebase Less syntax highlighting on SCSS one by committing R216:ca846fbda318: Rebased Less syntax highlighting on SCSS one.
Aug 19 2017, 2:07 PM · Frameworks, Framework: Syntax Highlighting

Aug 17 2017

gszymaszek updated the diff for D5799: Rebase Less syntax highlighting on SCSS one.

Removed leading and trailing spaces inside XML tags (in less.xml), to make it possible to build the framework.

Aug 17 2017, 5:03 PM · Frameworks, Framework: Syntax Highlighting

Jun 24 2017

gszymaszek updated the diff for D5799: Rebase Less syntax highlighting on SCSS one.

Added a test file (autotests/input/highlight.less).

Jun 24 2017, 10:18 AM · Frameworks, Framework: Syntax Highlighting

May 10 2017

gszymaszek created D5799: Rebase Less syntax highlighting on SCSS one.
May 10 2017, 6:17 PM · Frameworks, Framework: Syntax Highlighting

Feb 18 2017

gszymaszek added a comment to D4537: EditorConfig support.

Do you have commit rights? If not, paste your mail address and full name and I can push your change with you as author.

Feb 18 2017, 8:45 PM · Frameworks
gszymaszek updated the diff for D4537: EditorConfig support.

Updated to work with new cmake/FindEditorConfig.cmake.

Feb 18 2017, 8:22 PM · Frameworks

Feb 15 2017

gszymaszek updated the diff for D4537: EditorConfig support.

key and value are const.

Feb 15 2017, 10:36 AM · Frameworks
gszymaszek updated the diff for D4537: EditorConfig support.

Pulled check-variable-functions out of EditorConfig class, moved some variable definitions into main loop of parser.

Feb 15 2017, 10:34 AM · Frameworks

Feb 14 2017

gszymaszek updated the diff for D4537: EditorConfig support.

Simplified the constructor and reduced parser indentation.

Feb 14 2017, 7:41 PM · Frameworks
gszymaszek added a comment to D4537: EditorConfig support.

Yes, it was good when actual parsing was delegated to a separate function, but we’ve decided to merge all parsing-related functions.

Feb 14 2017, 7:31 PM · Frameworks
gszymaszek added a comment to D4537: EditorConfig support.

On the other side, I see no real copyrightable material beside you are using the editor config API.

Feb 14 2017, 7:25 PM · Frameworks
gszymaszek added a comment to D4589: EditorConfig module.

FindLibGit2.cmake and other files include such fragment:

Feb 14 2017, 1:19 PM · Frameworks, Build System
gszymaszek updated the diff for D4589: EditorConfig module.

Added description.

Feb 14 2017, 1:16 PM · Frameworks, Build System

Feb 13 2017

gszymaszek updated the diff for D4589: EditorConfig module.

Added version checking support.

Feb 13 2017, 8:42 PM · Frameworks, Build System
gszymaszek added a comment to D4589: EditorConfig module.

editorconfig-core-lua doesn’t check C library version (CMakeLists.txt:49). Actually I’m not sure if setting oldest acceptable version in KTextEditor is really needed.

Feb 13 2017, 6:16 PM · Frameworks, Build System
gszymaszek added a comment to D4589: EditorConfig module.

It seems there isn’t any version string in library headers (editorconfig.h, editorconfig_handle.h), is there any other cross-distribution way to obtain library version?

Feb 13 2017, 1:31 PM · Frameworks, Build System
gszymaszek updated the diff for D4537: EditorConfig support.

Fixed src/CMakeLists.txt to make EditorConfig support truly optional, removed interpret and interpretLine functions (so parsing is back in parse), simplified EditorConfig class constructor, fixed memory leak in DocumentPrivate.

Feb 13 2017, 11:26 AM · Frameworks
gszymaszek added inline comments to D4537: EditorConfig support.
Feb 13 2017, 10:31 AM · Frameworks
gszymaszek added a comment to D4537: EditorConfig support.

Btw, did you copy some code from another project? If so, we need to be careful, since KTextEditor is LGPLv+2.

Feb 13 2017, 10:15 AM · Frameworks

Feb 12 2017

gszymaszek retitled D4589: EditorConfig module from to EditorConfig module.
Feb 12 2017, 10:17 PM · Frameworks, Build System
gszymaszek updated the diff for D4537: EditorConfig support.

Moved EditorConfig-related logic into a separate class and made it optional (no longer a KTextEditor dependency).

Feb 12 2017, 9:36 PM · Frameworks
gszymaszek added a comment to D4537: EditorConfig support.

In the new EditorConfig class I need to use DocumentPrivate’s checkBoolValue and checkIntValue methods, but they’re declared private. I think it should be OK to make them public as they’re static anyway, but I’d like to hear what’s your opinion. Setting EditorConfig as DocumentPrivate’s friend didn’t help.

Feb 12 2017, 6:54 PM · Frameworks
gszymaszek added a comment to D4537: EditorConfig support.

Thanks for your comments. I’ve managed to make editorconfig optional using the mentioned FindEditorConfig.cmake module (I had to change its name to Findeditorconfig.cmake). Should I create a new diff in ECM repository to add this file?
Now I’m going to create a separate class for EditorConfig parsing.

Feb 12 2017, 5:27 PM · Frameworks

Feb 9 2017

gszymaszek retitled D4537: EditorConfig support from to EditorConfig support.
Feb 9 2017, 8:18 PM · Frameworks

Jan 26 2017

gszymaszek retitled D4300: Simpler calculation of longest line limit from to Simpler calculation of longest line limit.
Jan 26 2017, 8:26 PM · Frameworks, KTextEditor
gszymaszek retitled D4296: Fixed single line comments in Less starting new regions from to Fixed single line comments in Less starting new regions.
Jan 26 2017, 2:28 PM · Framework: Syntax Highlighting, Frameworks