• Add common HTML elements to the HTML file template

• Remove stylesheets from the HTML file template

In D29084#654484, @ognarb wrote:

• Don't include <style></syle>, it's not recommanded to inclde <style> elements but instead to link to a css file.

Fixed two links to docs.kde.org

• Removed JavaScript code blocks in Markdown support since it didn’t work
• Added test cases for new code blocks in Markdown

Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974).

Removed leading and trailing spaces inside XML tags (in less.xml), to make it possible to build the framework.

Added a test file (autotests/input/highlight.less).

In D4537#87411, @cullmann wrote:

Do you have commit rights? If not, paste your mail address and full name and I can push your change with you as author.

Updated to work with new cmake/FindEditorConfig.cmake.

key and value are const.

Pulled check-variable-functions out of EditorConfig class, moved some variable definitions into main loop of parser.

Simplified the constructor and reduced parser indentation.

Yes, it was good when actual parsing was delegated to a separate function, but we’ve decided to merge all parsing-related functions.

In D4537#86356, @cullmann wrote:

On the other side, I see no real copyrightable material beside you are using the editor config API.

FindLibGit2.cmake and other files include such fragment:

Added description.

Added version checking support.

editorconfig-core-lua doesn’t check C library version (CMakeLists.txt:49). Actually I’m not sure if setting oldest acceptable version in KTextEditor is really needed.

It seems there isn’t any version string in library headers (editorconfig.h, editorconfig_handle.h), is there any other cross-distribution way to obtain library version?

Fixed src/CMakeLists.txt to make EditorConfig support truly optional, removed interpret and interpretLine functions (so parsing is back in parse), simplified EditorConfig class constructor, fixed memory leak in DocumentPrivate.

In D4537#85846, @dhaumann wrote:

Btw, did you copy some code from another project? If so, we need to be careful, since KTextEditor is LGPLv+2.

Moved EditorConfig-related logic into a separate class and made it optional (no longer a KTextEditor dependency).

In the new EditorConfig class I need to use DocumentPrivate’s checkBoolValue and checkIntValue methods, but they’re declared private. I think it should be OK to make them public as they’re static anyway, but I’d like to hear what’s your opinion. Setting EditorConfig as DocumentPrivate’s friend didn’t help.

Thanks for your comments. I’ve managed to make editorconfig optional using the mentioned FindEditorConfig.cmake module (I had to change its name to Findeditorconfig.cmake). Should I create a new diff in ECM repository to add this file?
Now I’m going to create a separate class for EditorConfig parsing.