Differential D4296

Fixed single line comments in Less starting new regions
ClosedPublic
Actions

Authored by gszymaszek on Jan 26 2017, 2:28 PM.

Details

Reviewers
None
Group Reviewers
Framework: Syntax Highlighting
Commits
R216:72ca652acd16: less highlighting: Fix single line comments starting new regions
Summary

From bug 373002:

If you type // in a Less (LESSCSS) file, Kate incorrectly opens a new region (it should do it in case of multiline comment, /*…*/). If you try to hide that region (using the arrow that's next to line number) it actually hides everything in the file starting from the comment.

Fixing this bug requires removing ' beginRegion="lessComment" ' from line 924 (of less.xml) and incrementing file version number on line 3.

Single line comments are part of Less, as stated here:
http://lesscss.org/features/#features-overview-feature-comments

This diff fixes the mentioned issue for me.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gszymaszek updated this revision to Diff 10588.Jan 26 2017, 2:28 PM
gszymaszek retitled this revision from to Fixed single line comments in Less starting new regions.
gszymaszek updated this object.
gszymaszek edited the test plan for this revision. (Show Details)
gszymaszek added a reviewer: Framework: Syntax Highlighting.
gszymaszek set the repository for this revision to R216 Syntax Highlighting.
gszymaszek added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 26 2017, 2:28 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann added a subscriber: dhaumann.Feb 12 2017, 4:48 PM

A good patch, thanks!

Revision Contents
Changeset List

PathPackages
Mdata/syntax/less.xml (4 lines)

Diff 11251

View Options

data/syntax/less.xml

Loading...