michalsrb (Michal Srb)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 25 2018, 2:08 PM (59 w, 3 d)
Availability
Available

Recent Activity

Aug 16 2018

michalsrb added a comment to D14879: Fix VariableToolTip auto resizing..

I don't have permissions to push. Someone else please do it.

Aug 16 2018, 3:05 PM · KDevelop
michalsrb added a reviewer for D14879: Fix VariableToolTip auto resizing.: KDevelop.
Aug 16 2018, 2:35 PM · KDevelop
michalsrb requested review of D14879: Fix VariableToolTip auto resizing..
Aug 16 2018, 2:19 PM · KDevelop

Aug 14 2018

michalsrb requested review of D14838: Add ExplicitlyTyped flag to Declaration..
Aug 14 2018, 2:33 PM · KDevelop
michalsrb added a comment to D14826: inline note interface wip #2.

Thank you for working on this. This interface would work for the kdev-sourceinfo use case just as well as the old one.

Aug 14 2018, 1:53 PM · Frameworks, Kate

Aug 13 2018

michalsrb added inline comments to D14479: Store sizeof and friends as numbers instead of comment..
Aug 13 2018, 3:20 PM · KDevelop
michalsrb added a comment to D12662: Add InlineNoteInterface.

I'd like to play with this a bit wrt what can be done in KDevelop with it (I want the problem popups gone). Would you mind if I do some changes along the way? I would post an updated patch here, in case I actually come up with useful changes ...

Aug 13 2018, 12:34 PM · Frameworks, Kate
michalsrb added a comment to D14479: Store sizeof and friends as numbers instead of comment..

Thank you for the review. I did the changes to ClassMemberDeclaration::setAlignOf.

Aug 13 2018, 11:58 AM · KDevelop
michalsrb updated the diff for D14479: Store sizeof and friends as numbers instead of comment..

Fixes in ClassMemberDeclaration::setAlignOf.

Aug 13 2018, 11:56 AM · KDevelop
michalsrb added a comment to D12662: Add InlineNoteInterface.

Sorry, I had almost no time to work on it. I got stuck trying to figure out how to properly handle the notes at the beginning of the lines.

Aug 13 2018, 7:03 AM · Frameworks, Kate

Aug 9 2018

michalsrb updated the diff for D14479: Store sizeof and friends as numbers instead of comment..

Document the -1 value and store alignOf as exponent.

Aug 9 2018, 8:26 AM · KDevelop

Aug 6 2018

michalsrb added a reviewer for D14479: Store sizeof and friends as numbers instead of comment.: KDevelop.
Aug 6 2018, 8:33 AM · KDevelop

Jul 30 2018

michalsrb added a comment to D14479: Store sizeof and friends as numbers instead of comment..

The open question is whether the values should be stored as int64_t. I have chosen it because that is what the clang querying functions return. But in typical scenarios the values will be lot smaller - especially the align of.

Jul 30 2018, 9:49 AM · KDevelop
michalsrb requested review of D14479: Store sizeof and friends as numbers instead of comment..
Jul 30 2018, 9:45 AM · KDevelop

Jun 14 2018

michalsrb abandoned D13536: Do not cancel old clipboard selection if it is same as the new one..

Already submitted: https://phabricator.kde.org/D13535

Jun 14 2018, 2:38 PM · Frameworks
michalsrb requested review of D13536: Do not cancel old clipboard selection if it is same as the new one..
Jun 14 2018, 12:52 PM · Frameworks

May 2 2018

michalsrb added a comment to D12662: Add InlineNoteInterface.

Looks good from the implementation too so far. One thing I do not see is any changes to the cursorToX / xToCursor functions, is there really no change required there?

May 2 2018, 7:36 PM · Frameworks, Kate
michalsrb added a comment to D12662: Add InlineNoteInterface.

Here are screenshots from the sample plugin:

May 2 2018, 6:25 PM · Frameworks, Kate
michalsrb added a reviewer for D12662: Add InlineNoteInterface: KTextEditor.
May 2 2018, 1:33 PM · Frameworks, Kate
michalsrb added a comment to D12662: Add InlineNoteInterface.

This is my first attempt to propose such API, it may not be ideal.

May 2 2018, 1:33 PM · Frameworks, Kate
michalsrb requested review of D12662: Add InlineNoteInterface.
May 2 2018, 1:27 PM · Frameworks, Kate