clang: include tooltips: fix range check
ClosedPublic

Authored by brauch on Aug 15 2018, 7:48 PM.

Details

Summary

The clang plugin would always show the include navigation tooltip
if the cursor was anywhere on the line, since it was never checking
whether the cursor actually contains the word range.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
brauch created this revision.Aug 15 2018, 7:48 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 15 2018, 7:48 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
brauch requested review of this revision.Aug 15 2018, 7:48 PM
kfunk accepted this revision.Aug 16 2018, 7:43 AM
This revision is now accepted and ready to land.Aug 16 2018, 7:43 AM
This revision was automatically updated to reflect the committed changes.
brauch added a comment.Wed, Sep 5, 7:56 AM

I'm super confused by the diff phabricator shows below but the commited changes are correct (and different from the diff here) ... what's going on?