[RFC] Fix block mode for multi-cursor branch
Needs ReviewPublic

Authored by lepagevalleeemmanuel on Aug 16 2018, 11:44 PM.



This is a rough patch to allow cursors past the end of the line when the "new block mode" action is checked. It doesn't improve that much upon the "it's fully broken" current state, but at least restore the capability to select past the end of the line and create multi-row vertical cursors using the keyboard.

This is a "code dump" more than a "I will be responsive forever about this code review". I said I would fix this and this patch does it. I hope it helps give some energy back into this branch and I hope it gets merged in the future.

Test Plan

none, it's barely working.

Diff Detail

R39 KTextEditor
Lint Skipped
Unit Tests Skipped
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 16 2018, 11:44 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
lepagevalleeemmanuel requested review of this revision.Aug 16 2018, 11:44 PM

Thanks for the patch, the approach looks reasonable at a first glance. You might want to unite the up/down functions ...
It is too much of a WiP to merge it like this, though.