Clean up unneeded JSON depends in kcoreaddons_add_plugin
Open, Needs TriagePublic

Description

From discussion in https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/107.

The function does not require one to explicitly define the JSON file. The moc process automatically reacts to changes in the file and rebuilds the plugin if needed.
This is done using https://api.kde.org/ecm/module/ECMSetupQtPluginMacroNames.html.

Only if the JSON file is created during the build it might be necessary, but then the kcoreaddons_desktop_to_json function is used anyways. In case the file gets configured for example to inject version information the changes are correctly picked up, this is used in ark already.

Consequently we should remove the parameters from the (hundreds of) function calls, mark the option as deprecated and add a version guard to ignore the parameter when the ECM find version is increased.

alex created this task.Jun 28 2021, 4:11 PM
alex added a comment.EditedJul 28 2021, 7:51 AM

https://invent.kde.org/kdevelop/kdevelop/-/commit/d738fe51c9efde530237f8b4618b2abaff1a8c2a
https://invent.kde.org/education/cantor/commit/a86f70afc5c6f99b8123c992b92909e7b8fa3fdb
https://invent.kde.org/network/kdeconnect-kde/commit/30d895d868b93655c3b00978d2b73793a1596018
https://invent.kde.org/pim/akonadi-import-wizard/commit/868f97806e5593116f7310e4b6bd774208b21705
https://invent.kde.org/pim/kdepim-runtime/commit/08427db79d6da064b82e8dcb5b66e5f61c0ff3d4
https://invent.kde.org/office/calligra/commit/249a816d29b52ed9783330fc046b291008e837f4
https://invent.kde.org/multimedia/k3b/commit/ebb6283ae2e9effd402ba654f27a1242a99f5c82
https://invent.kde.org/utilities/ark/commit/fd14c53b29c5e0b6b46d61b445fa91c451a1ab2d
https://invent.kde.org/plasma/kactivitymanagerd/commit/b3214fac2b5c44bb563393de797a5e31b2e1d5b1
https://invent.kde.org/plasma/lancelot/commit/70630c7a9419a903a6a78c8a8599048f95b2ab07
https://invent.kde.org/utilities/symmy/commit/639112bdae63d5e3a88f43f5943d5b499ef9fda2
https://invent.kde.org/libraries/baloo-widgets/commit/7c1aaf3370309e779c66c4db45bb20cdb100b33d
https://invent.kde.org/sdk/dolphin-plugins/commit/81a72bf849f9bce512b8fb575e5cd4fe80959508
https://invent.kde.org/network/kaccounts-integration/commit/90bb6da28193576a9ba94d8582cc359d88468b4a
https://invent.kde.org/graphics/gwenview/commit/b292af50a573fcf479e3c487e95cc94155a34331
https://invent.kde.org/frameworks/kemoticons/commit/de2d0fb3c1c73dbe5fdf3b97e876eee8cf1a01da
https://invent.kde.org/pim/kmail/commit/fcf8afc62577a7f69efc0c6356e5df4345418197
https://invent.kde.org/plasma/plasma-firewall/commit/fe33df5acdd7fe8e7d6cdd91065b6f1d04411319
https://invent.kde.org/plasma/plasma-vault/commit/076e3f105aa46e834b11d705c5e391247cb27f17
https://invent.kde.org/frameworks/purpose/commit/599e08ddb24a692eda7c8c880867078b71ee5edf
https://invent.kde.org/network/kio-extras/commit/767d1ff849a6db392de76356540e53c77afb9fc6
https://invent.kde.org/office/kmymoney/-/commit/d1b824ff59a7b1a69bd49967a14ec675661aeee1
https://invent.kde.org/frameworks/kimageformats/-/commit/aade392da3dd0181bcf5edc9a5992fa3005ae771

alex moved this task from Backlog to Waiting on KF6 Branching on the KF6 board.Aug 24 2021, 10:08 AM