Create Task
Maniphest T14306

Core/Gui split for KUriFilterPlugin
Open, Needs TriagePublic
Actions

Description

KUriFilter / KUriFilterPlugin:

  • Deprecate configModule() virtual method, let the plugins provide the KCModule as a separate plugin object, separate from KUriFilterPlugin
  • Then in KF6 KUriFilter and KUriFilterPlugin can move to KIOCore
  • Then change the target_link_libraries for all urifilter plugins.

Related Objects
Search...

dfaure created this task.Mar 28 2021, 10:05 AM
dfaure claimed this task.Apr 5 2021, 9:03 AM
dfaure moved this task from Backlog to In Progress on the KF6 board.
dfaure added a comment.Apr 5 2021, 11:02 AM

I think it will have to move all to KIOGui because of the KIconLoader usage.

dfaure moved this task from In Progress to Waiting on KF6 Branching on the KF6 board.Apr 6 2021, 1:24 PM

kio !396 is in, the final cleanup and move is for after KF6 branching

nicolasfella added a subscriber: nicolasfella.Feb 4 2023, 2:10 PM

https://invent.kde.org/frameworks/kio/-/merge_requests/1180 cleans up the unused functions

we can't move it to KIOGui as-is because it's using KIconThemes internally, which pulls widgets in

tfella added a subscriber: tfella.Apr 4 2023, 4:55 PM
In T14306#287376, @nicolasfella wrote:

https://invent.kde.org/frameworks/kio/-/merge_requests/1180 cleans up the unused functions

we can't move it to KIOGui as-is because it's using KIconThemes internally, which pulls widgets in

The dependency on KIconThemes seems to only be for KIconLoader, for a single check on whether an Icon exists - that seems like something we could get rid of

nicolasfella added a comment.Jun 28 2023, 10:59 AM

Moving to Gui is unblocked with https://invent.kde.org/frameworks/kiconthemes/-/merge_requests/88

If we got rid of the KIconLoader usage we could also move it to core

alex claimed this task.Jul 11 2023, 3:41 PM
nicolasfella moved this task from In Progress to Done on the KF6 board.Oct 19 2023, 10:14 PM