KPackage: make KPackage::install()'s KJob return a new Package copy rather than modify argument in

Open, Needs TriagePublic

Actions

See

src/kpackage/private/package_p.h://TODO KF6 - make KPackage::install()'s KJob return a new Package copy rather than modify

(commit log should contain rationale when I added that TODO)

Though then we'd need to expose the KJob subclass publicly. Though I do not understand why this is not an issue in KNewStuff, in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/227 I did some refactorings.

KPackage::Package package(structure);
 package.setPath(payloadfile);

 if (package.isValid() && package.metadata().isValid()) {
     KJob *installJob = package.install(payloadfile, packageRoot);
     connect(installJob, &KJob::result, this, [this, entry, payloadfile, expectedDir, resetEntryStatus](KJob *job) {

Relevant commit: https://invent.kde.org/frameworks/kpackage/-/commit/cfb69e21fb0aad92f403487b4c8a75b2b0bc8041

Makes sense, then it is a cleanup of the internal API and does not fix a crash anymore