With the install namespace and the JSON metadata this is obsolete.
Especially that we explicitly define the service file in the kcoreaddons_desktop_to_json command and don't have any version checks which install the old desktop file we should drop those completely. That also includes removing the unneeded filtering of the plugin meta data based on the service type, like in https://invent.kde.org/plasma/kdeplasma-addons/-/blob/master/dataengines/potd/potd.cpp#L52